Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oFocusInfo lacks documentation #4010

Closed
jvanattedev opened this issue Mar 19, 2024 · 2 comments
Closed

oFocusInfo lacks documentation #4010

jvanattedev opened this issue Mar 19, 2024 · 2 comments

Comments

@jvanattedev
Copy link

OpenUI5 version: any

Browser/version (+device/version): n.a.

Any other tested browsers/devices(OK/FAIL): n.a.

URL (minimal example if possible): https://sapui5.hana.ondemand.com/#/api/sap.ui.core.Element%23methods/focus

User/password (if required and possible - do not post any confidential information here):

The focus function lacks documentation. It mensions oFocusInfo as an argument. This contains 'targetInfo' with type 'any' (?). What information or type are we supposed to provide to this function, to all these arguments?

This oFocusInfo contains different information compare to the one in, looking at the signature of the method:
https://sapui5.hana.ondemand.com/#/api/sap.ui.core.Element%23methods/applyFocusInfo

Is that a correct assumption?

@TeodorTaushanov
Copy link
Member

Hello @jvanattedev,

Thank you for sharing this finding. I've created an internal incident DINC0098637. The status of the issue will be updated here in
GitHub.

Regards,
Teodor

@aborjinik
Copy link
Contributor

Hello @jvanattedev Element#focus as a base class method defines the focus possibilities and as documented it defines "Further control-specific setting of the focus target within the control". So if want to know that its type should be or whether it should be provided or not must be documented by the controls.
e.g. sap.m.Table defines the targetInfo as
"If oFocusInfo.targetInfo is of type sap.ui.core.message.Message, the focus will be set as accurately as possible according to the information provided by sap.ui.core.message.Message."
https://sapui5.hana.ondemand.com/#/api/sap.m.Table%23methods/focus

I guess we cannot define this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants