Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexBox Issue On Chrome #66

Closed
amjadghazisas opened this issue Jun 9, 2014 · 3 comments
Closed

FlexBox Issue On Chrome #66

amjadghazisas opened this issue Jun 9, 2014 · 3 comments

Comments

@amjadghazisas
Copy link

OpenUI5 version:

Browser/version (+device/version): Version 34.0.1847.131 m

Any other tested browsers/devices(OK/FAIL): FireFox

URL (minimal example if possible): http://jsbin.com/jelexizo/8/edit

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Created a nested FlexBox with ScrollContainer with one of the containing controls
  2. Run the sample on chrome and Firefox
  3. The output on chrome is incorrect but the outcome on Firefox is correct

What is the expected result? The layout should render correctky in Flexbox to include ScrollContainer correctly

What happens instead? The ScrollContainer is thrown out side the layout

Any other information? (attach screenshot if possible) The code and running sample are available here:

http://jsbin.com/jelexizo/8/edit

@jmoors
Copy link

jmoors commented Jun 9, 2014

It seems to be related to the nested flex boxes and the height being set to 100%.I noticed in the FlexboxRenderer that this is a specific check for ScrollContainers, not sure if this is necessary, however the flex box seems to be displayed correctly if I remove.

// ScrollContainer needs height:100% on the flex item
if(aChildren[i] instanceof sap.m.ScrollContainer) {
oRm.addStyle("height", "100%");
}

http://stackoverflow.com/questions/20959600/height-100-on-flexbox-column-child

Regards,
Jason

@aborjinik aborjinik added the bug label Jun 9, 2014
@aborjinik
Copy link
Contributor

I think the source of the issue is again FlexItem wrapper. At least it should not be applied for the browsers that support latest flex box spec.

@machwitt
Copy link
Contributor

machwitt commented Oct 9, 2014

Hi,
the flexbox issue has already been described in #49.
It has been added to our backlog but has not been resolved yet.

Since this is issue a duplicate, I will close it.
Thanks for reporting,
Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants