Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Connection Strings should be configurable #71

Closed
clupasq opened this issue Oct 14, 2015 · 1 comment
Closed

Test Connection Strings should be configurable #71

clupasq opened this issue Oct 14, 2015 · 1 comment

Comments

@clupasq
Copy link
Contributor

clupasq commented Oct 14, 2015

Currently, the SQL Connection Strings used for the tests are hardcoded in the src/Test/Config.cs file.

Not all contributors have a local database instance with the same name/credentials and I think it would be nice to provide some minimal flexibility in this case.

My idea would be to use some predefined ConnectionStrings settings that every developer would be able to configure in his/her local machine.config file. In case any of the necessary connection strings are not defined, we should fall back to the default (hardcoded) ones.

@sapiens
Copy link
Owner

sapiens commented Oct 14, 2015

I get what you're saying, but at this moment I think it doesn't bring any benefits. To be honest, I doubt that many developers would change their machine.config (which AFAIK requires a reboot) just to run some SqlFu tests. It's much easier to just change the connection string directly and then change it back.

@sapiens sapiens closed this as completed Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants