New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle panics #4

Open

sapir opened this issue Dec 24, 2019 · 4 comments

Owner

sapir commented Dec 24, 2019 •

edited

Loading

Panics are currently skipped

Terminator::Call cleanup edge
Terminator::Assert
Terminator::FalseEdges?
Terminator::FalseUnwind?
Terminator::Resume
Terminator::Abort

bjorn3 commented Dec 24, 2019

False* are desugared. Assert is codegened at https://github.com/rust-lang/rust/blob/a9c1c04e986dbf610be8cbe6a8107f90b4db61ce/src/librustc_codegen_ssa/mir/block.rs#L359. Abort just needs to codegen to for example ud2 on x86.

Owner Author

sapir commented Dec 24, 2019 •

edited

Loading

False* are desugared.

Do you mean that I can ignore them or that they will never show up? (edit: or that they should be replaced with something else?)

Owner Author

sapir commented Dec 24, 2019

And thanks for all the help!

bjorn3 commented Dec 25, 2019

Do you mean that I can ignore them or that they will never show up?

They will never show up after borrowck.

And thanks for all the help!

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment