Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize pretty print settings #780

Closed
pokrakam opened this issue Jul 18, 2021 · 5 comments · Fixed by #781
Closed

Harmonize pretty print settings #780

pokrakam opened this issue Jul 18, 2021 · 5 comments · Fixed by #781
Assignees

Comments

@pokrakam
Copy link
Contributor

In the same principle as #773, different code uses different styles for keyword/identifier upper/lower case.

Propose standardising on the most commonly used format of keyword upper / identifier lower case to minimise large diffs due to pretty print.

See also Style Guides on the topic.

@pokrakam pokrakam mentioned this issue Jul 18, 2021
@larshp
Copy link
Member

larshp commented Jul 18, 2021

also see #658

@pokrakam
Copy link
Contributor Author

pokrakam commented Jul 18, 2021

Didn't spot that one. I did search for an issue about this, but only open ones.

@AndreaBorgia-Abo
Copy link
Member

So, if I understand it correctly, this should be once-in-project-lifetime occurrence: once the "keywords in uppercase / identifiers in lowercase" consensus reached in #658 is implemented, we shouldn't have to deal with this issue any more.
In this case, I'll move this one to my todolist and review it quickly.

@AndreaBorgia-Abo AndreaBorgia-Abo self-assigned this Jul 26, 2021
@pokrakam
Copy link
Contributor Author

Correct, and with abapLint we can verify that all PRs conform in future.

@AndreaBorgia-Abo
Copy link
Member

Guess I'll now have to learn how to deploy the linter in my setup, now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants