Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*)!: absorb changes from result@2.0.0 #468

Merged
merged 31 commits into from
Aug 4, 2022
Merged

refactor(*)!: absorb changes from result@2.0.0 #468

merged 31 commits into from
Aug 4, 2022

Conversation

c43721
Copy link
Contributor

@c43721 c43721 commented Jun 26, 2022 •
edited
Loading

Everything is awesome!

c43721
c43721 commented Jun 26, 2022
View reviewed changes
Copy link
Contributor Author

@c43721 c43721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments I noted while doing this chore

package.json Outdated Show resolved Hide resolved
src/lib/structures/ExtendedArgument.ts Outdated Show resolved Hide resolved
src/lib/structures/InteractionHandlerStore.ts Outdated Show resolved Hide resolved
src/lib/structures/InteractionHandlerStore.ts Outdated Show resolved Hide resolved
src/lib/utils/resolvers/resolveGuildChannelPredicate.ts Outdated Show resolved Hide resolved
@c43721
Copy link
Contributor Author

c43721 commented Jun 26, 2022

GH doesn't want you to know that https://github.com/sapphiredev/framework/pull/468/files#diff-a46c82e284b62508ce9b0631bb80343e000fd9c32072bf593f26174456c43b5bR97 also needs a change- looks like it's a helper type.

@c43721 c43721 changed the title chore(*): absorb changes from result@2.0.0 WIP: chore(*)!: absorb changes from result@2.0.0 Jun 26, 2022
favna
favna reviewed Jun 26, 2022
View reviewed changes
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCREAM
(also finally)

@c43721
Copy link
Contributor Author

c43721 commented Jun 26, 2022 •
edited by favna
Loading

Dependant on 1Computer1/lexure#9 due to the types mismatch.

Edit by Favna: We have decided to make our own lexure package because the linked PR will not be accepted as has been communicated to @kyranet by 1Computer1.

@c43721
Copy link
Contributor Author

c43721 commented Jul 3, 2022

Now dependant on sapphiredev/utilities#388

Will update branch when that is merged.

@kyranet
Copy link
Member

kyranet commented Jul 22, 2022

The package has been released, this PR's work can now be continued.

@c43721
Copy link
Contributor Author

c43721 commented Jul 22, 2022

Will be on it this weekend.

@c43721 c43721 force-pushed the chore/result-2 branch 2 times, most recently from cc7f114 to 256576b Compare July 22, 2022 21:28
@favna favna added this to the v3 milestone Jul 24, 2022
@samfundev
Copy link
Contributor

This PR should fix #493 with 13ada1f.

@c43721 c43721 marked this pull request as ready for review July 28, 2022 00:50
@c43721 c43721 requested a review from vladfrangu as a code owner July 28, 2022 00:50
@c43721 c43721 changed the title WIP: chore(*)!: absorb changes from result@2.0.0 chore(*)!: absorb changes from result@2.0.0 Jul 28, 2022
favna
favna requested changes Jul 28, 2022
View reviewed changes
src/lib/parsers/Args.ts Outdated Show resolved Hide resolved
src/lib/structures/Command.ts Outdated Show resolved Hide resolved
src/lib/structures/Command.ts Outdated Show resolved Hide resolved
kyranet
kyranet requested changes Jul 28, 2022
View reviewed changes
src/arguments/CoreBoolean.ts Outdated Show resolved Hide resolved
src/lib/parsers/Args.ts Outdated Show resolved Hide resolved
src/lib/parsers/Args.ts Outdated Show resolved Hide resolved
src/lib/parsers/Args.ts Outdated Show resolved Hide resolved
src/lib/parsers/Args.ts Outdated Show resolved Hide resolved
src/lib/utils/strategies/FlagUnorderedStrategy.ts Outdated Show resolved Hide resolved
src/listeners/application-commands/chat-input/CoreChatInputCommandAccepted.ts Outdated Show resolved Hide resolved
src/listeners/application-commands/context-menu/CoreContextMenuCommandAccepted.ts Outdated Show resolved Hide resolved
src/optional-listeners/message-command-listeners/CoreMessageCommandAccepted.ts Outdated Show resolved Hide resolved
tests/resolvers/boolean.test.ts Outdated Show resolved Hide resolved
@favna favna linked an issue Jul 28, 2022 that may be closed by this pull request
Update Args to use @sapphire/lexure #493
Closed
@c43721 c43721 mentioned this pull request Jul 29, 2022
Merged
@c43721
Copy link
Contributor Author

c43721 commented Jul 30, 2022

Status: needs testing.

@c43721 c43721 requested review from kyranet and favna August 4, 2022 01:17
kyranet
kyranet requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For real now, the last two things.

src/lib/structures/InteractionHandlerStore.ts Outdated Show resolved Hide resolved
src/lib/structures/InteractionHandlerStore.ts Outdated Show resolved Hide resolved
favna and others added 3 commits August 4, 2022 15:04
@favna @kyranet
Update src/lib/structures/InteractionHandlerStore.ts
868f63b 
Co-authored-by: A. Román <kyradiscord@gmail.com>
@favna @kyranet
Update src/lib/structures/InteractionHandlerStore.ts
1ecbe72 
Co-authored-by: A. Román <kyradiscord@gmail.com>
@kyranet
fix: resolved issues
f1b489c
kyranet
kyranet previously approved these changes Aug 4, 2022
View reviewed changes
favna
favna previously approved these changes Aug 4, 2022
View reviewed changes
@favna favna dismissed stale reviews from kyranet and themself via 63a059f August 4, 2022 19:49
@kyranet kyranet mentioned this pull request Aug 4, 2022
Merged
@favna favna changed the title chore(*)!: absorb changes from result@2.0.0 refactor(*)!: absorb changes from result@2.0.0 Aug 4, 2022
@favna favna merged commit 3626512 into sapphiredev:main Aug 4, 2022
@c43721
Copy link
Contributor Author

c43721 commented Aug 4, 2022

wohoo!

@c43721 c43721 deleted the chore/result-2 branch August 4, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samfundev samfundev samfundev left review comments

@feefs feefs feefs left review comments

@favna favna favna approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

Assignees

@c43721 c43721

Labels
help wanted priority:high semver:major
Projects
Sapphire
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.

Update Args to use @sapphire/lexure
6 participants
@c43721 @kyranet @samfundev @favna @vladfrangu @feefs