feat: remove CommandChatInputRegisterShortcut alias interface, prefer using ApplicationCommandRegistry.RegisterOptions instead
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ias for `ApplicationCommandRegistry.RegisterOptions` The old interface exposed options that were not actually supported by Sapphire, which was misleading. The whole interface could in fact be removed, but that would be a breaking change, so for now we mark it as deprecated and make it a type alias. While normally removing interface options would be a breaking change too, these particular options already did absolutely nothing and weren't being read anywhere anymore. Anyone who still had this option and will get a TypeScript build error can simply remove the options.
|
I'd rather we just remove it in a minor version. since it's not used anywhere it's not like it'd matter (yes I KNOW semver and all) |
favna
changed the title
ApplicationCommandRegistry.RegisterOptionsApplicationCommandRegistry.RegisterOptions
favna
changed the title
ApplicationCommandRegistry.RegisterOptionsApplicationCommandRegistry.RegisterOptions
favna
changed the title
ApplicationCommandRegistry.RegisterOptionsCommandChatInputRegisterShortcut alias interface, prefer using ApplicationCommandRegistry.RegisterOptions instead
|
@sapphiredev pack |
|
Hey @favna, I've released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-597 |
vladfrangu
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old interface exposed options that were not actually supported
by Sapphire, which was misleading. The whole interface could in fact
be removed as it is was an alias for
ApplicationCommandRegistry.RegisterOptions.Arguebly a breaking change for TypeScript users, but because the transition to
ApplicationCommandRegistry.RegisterOptionsis a simple find-and-replace we are pushing this out in a minor version.