Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove CommandChatInputRegisterShortcut alias interface, prefer using ApplicationCommandRegistry.RegisterOptions instead #597

Merged
merged 2 commits into from
Feb 5, 2023
Merged

feat: remove CommandChatInputRegisterShortcut alias interface, prefer using ApplicationCommandRegistry.RegisterOptions instead #597

merged 2 commits into from
Feb 5, 2023

Commits on Feb 5, 2023

  1. feat(CommandChatInputRegisterShortcut): change interaction to type al… 

    …ias for `ApplicationCommandRegistry.RegisterOptions`

The old interface exposed options that were not actually supported
by Sapphire, which was misleading. The whole interface could in fact
be removed, but that would be a breaking change, so for now we mark
it as deprecated and make it a type alias.

While normally removing interface options would be a breaking change too,
these particular options already did absolutely nothing and weren't
being read anywhere anymore. Anyone who still had this option and
will get a TypeScript build error can simply remove the options.
    @favna
    favna committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    7584579 View commit details
    Browse the repository at this point in the history

  2. chore: remove interface

    @favna
    favna committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    0df770f View commit details
    Browse the repository at this point in the history