fix(ApplicationCommandRegistries): add the right ids in the right place #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't break anything funnily enough but its technically wrong
kyranet
previously approved these changes
Jan 12, 2024
|
@sapphiredev pack this pls |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at 2eb6ec8. You can monitor the build here! |
|
Hey @vladfrangu, I've released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-716 |
|
@sapphiredev pack this pls |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at ddccc23. You can monitor the build here! |
kyranet
approved these changes
Jan 12, 2024
favna
approved these changes
Jan 13, 2024
favna
deleted the
fix/correctly-set-ids-to-right-places-for-bulk-overwrite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't break anything funnily enough but its technically wrong