Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ApplicationCommandRegistries): add the right ids in the right place #716

Merged
merged 6 commits into from
Jan 13, 2024
Merged

fix(ApplicationCommandRegistries): add the right ids in the right place #716

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fb0a76
fix(ApplicationCommandRegistries): add the right ids in the right place
vladfrangu Jan 12, 2024
2eb6ec8
fix: proper fix for the issue
vladfrangu Jan 12, 2024
ddccc23
chore: proper split
vladfrangu Jan 12, 2024
859d3c9
chore: dumbass 100
vladfrangu Jan 12, 2024
637930e
chore: document commandName
vladfrangu Jan 12, 2024
478f77e
chore: kyra nits
vladfrangu Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/lib/utils/application-commands/ApplicationCommandRegistries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { container } from '@sapphire/pieces';
import type { RESTPostAPIApplicationCommandsJSONBody } from 'discord-api-types/v10';
import type { ApplicationCommandManager } from 'discord.js';
import { ApplicationCommandType, type ApplicationCommandManager } from 'discord.js';
import type { Command } from '../../structures/Command';
import type { CommandStore } from '../../structures/CommandStore';
import { RegisterBehavior } from '../../types/Enums';
Expand Down Expand Up @@ -126,7 +126,18 @@ export async function handleBulkOverwrite(commandStore: CommandStore, applicatio
const registry = piece.applicationCommandRegistry;

registry.globalCommandId = id;
registry.addChatInputCommandIds(id);

switch (globalCommand.type) {
case ApplicationCommandType.ChatInput: {
registry.addChatInputCommandIds(id);
break;
}
case ApplicationCommandType.User:
case ApplicationCommandType.Message: {
registry.addContextMenuCommandIds(id);
break;
}
}

// idHints are useless, and any manually added id or names could end up not being valid any longer if you use bulk overwrites
// That said, this might be an issue, so we might need to do it like `handleAppendOrUpdate`
Expand Down Expand Up @@ -163,7 +174,17 @@ export async function handleBulkOverwrite(commandStore: CommandStore, applicatio
const registry = piece.applicationCommandRegistry;
registry.guildCommandIds.set(guildId, id);

registry.addChatInputCommandIds(id);
switch (guildCommand.type) {
case ApplicationCommandType.ChatInput: {
registry.addChatInputCommandIds(id);
break;
}
case ApplicationCommandType.User:
case ApplicationCommandType.Message: {
registry.addContextMenuCommandIds(id);
break;
}
}

// idHints are useless, and any manually added ids or names could no longer be valid if you use bulk overwrites.
// That said, this might be an issue, so we might need to do it like `handleAppendOrUpdate`
Expand Down