Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disabling of validators #125

Merged
merged 6 commits into from
Jun 11, 2022
Merged

feat: add disabling of validators #125

merged 6 commits into from
Jun 11, 2022

Conversation

vladfrangu
Copy link
Member

No description provided.

src/index.ts Outdated Show resolved Hide resolved
src/validators/BaseValidator.ts Show resolved Hide resolved
@vladfrangu vladfrangu requested a review from kyranet June 9, 2022 11:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #125 (100613c) into main (8944a49) will decrease coverage by 0.06%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   99.79%   99.73%   -0.07%     
==========================================
  Files          50       51       +1     
  Lines        1460     1494      +34     
  Branches      311      320       +9     
==========================================
+ Hits         1457     1490      +33     
- Misses          3        4       +1     
Impacted Files Coverage Δ
src/validators/RecordValidator.ts 96.42% <75.00%> (-3.58%) ⬇️
src/index.ts 100.00% <100.00%> (ø)
src/lib/configs.ts 100.00% <100.00%> (ø)
src/validators/ArrayValidator.ts 100.00% <100.00%> (ø)
src/validators/BaseValidator.ts 100.00% <100.00%> (ø)
src/validators/MapValidator.ts 100.00% <100.00%> (ø)
src/validators/ObjectValidator.ts 98.13% <100.00%> (+0.02%) ⬆️
src/validators/SetValidator.ts 100.00% <100.00%> (ø)
src/validators/TupleValidator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8944a49...100613c. Read the comment docs.

src/validators/BaseValidator.ts Outdated Show resolved Hide resolved
src/validators/BaseValidator.ts Outdated Show resolved Hide resolved
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Kyra's comments other than that lgtm

src/validators/BaseValidator.ts Outdated Show resolved Hide resolved
@favna favna merged commit e17af95 into main Jun 11, 2022
@favna favna deleted the feat/disable-validation branch June 11, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants