Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Typed Array #78

Merged
merged 42 commits into from
Apr 29, 2022
Merged

feat: add Typed Array #78

merged 42 commits into from
Apr 29, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Mar 21, 2022

This pr adds all the typed arrays.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #78 (c471504) into main (f7e3d67) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main       #78    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           46        50     +4     
  Lines         1201      1387   +186     
  Branches       254       285    +31     
==========================================
+ Hits          1201      1387   +186     
Impacted Files Coverage Δ
src/lib/errors/BaseConstraintError.ts 100.00% <ø> (ø)
src/constraints/TypedArrayLengthConstraints.ts 100.00% <100.00%> (ø)
src/constraints/util/common/vowels.ts 100.00% <100.00%> (ø)
src/constraints/util/typedArray.ts 100.00% <100.00%> (ø)
src/lib/Shapes.ts 100.00% <100.00%> (ø)
src/validators/TypedArrayValidator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e3d67...c471504. Read the comment docs.

@imranbarbhuiya imranbarbhuiya marked this pull request as ready for review March 21, 2022 11:17
src/constraints/util/typedArray.ts Outdated Show resolved Hide resolved
src/validators/TypedArrayValidator.ts Outdated Show resolved Hide resolved
src/validators/TypedArrayValidator.ts Outdated Show resolved Hide resolved
src/constraints/util/typedArray.ts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/constraints/util/typedArray.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/validators/typedArray.test.ts Outdated Show resolved Hide resolved
vladfrangu
vladfrangu previously approved these changes Apr 27, 2022
README.md Outdated Show resolved Hide resolved
@favna favna merged commit ca5ea5f into sapphiredev:main Apr 29, 2022
@imranbarbhuiya imranbarbhuiya deleted the typedArray branch April 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants