Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header files not using relative includes. #95

Closed
ghost opened this issue Sep 12, 2021 · 1 comment
Closed

Header files not using relative includes. #95

ghost opened this issue Sep 12, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 12, 2021

Some of your header files still use angled brackets (< and >), which requires someone to include the folder these headers reside during compilation.

Better solution is to just use quotes, which you seem to have used in plibsys.h, but every other header seems to use the angled brackets.

Currently this breaks me being able to use the library outside of placing the whole git repo in my project's directory.
As my headers reside in one folder deeper than my default system-wide include folder.

plibsys/plibsys.h as an example.

This is a relatively simple fix, as well.

@saprykin
Copy link
Owner

saprykin commented Jul 2, 2023

The idea behind is to only use plibsys.h header in a program, the rest headers should never be included by hand. For that, you typically use CMake and add an include path. In general, installation can be different and you should not rely on relative paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant