Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional no std/rayon #73

Merged
merged 8 commits into from
Oct 13, 2023
Merged

optional no std/rayon #73

merged 8 commits into from
Oct 13, 2023

Conversation

sarah-quinones
Copy link
Owner

No description provided.

@CGMossa
Copy link

CGMossa commented Oct 13, 2023

I would vote for enabling rayon by default, even though that is odd... 🤷‍♂️

But either way is cool!

@sarah-quinones
Copy link
Owner Author

rayon is enabled by default. the last commit was just to disable global parallelism in no-rayon builds

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (22daf13) 91.36% compared to head (2aa751c) 91.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   91.36%   91.42%   +0.05%     
==========================================
  Files          56       56              
  Lines       60626    60613      -13     
==========================================
+ Hits        55393    55413      +20     
+ Misses       5233     5200      -33     
Files Coverage Δ
faer-cholesky/src/ldlt_diagonal/compute.rs 92.90% <ø> (ø)
faer-cholesky/src/ldlt_diagonal/solve.rs 29.31% <ø> (ø)
faer-cholesky/src/ldlt_diagonal/update.rs 88.58% <ø> (ø)
faer-cholesky/src/lib.rs 0.00% <ø> (ø)
faer-cholesky/src/llt/compute.rs 92.77% <ø> (ø)
faer-cholesky/src/llt/inverse.rs 75.40% <ø> (ø)
faer-cholesky/src/llt/reconstruct.rs 59.52% <ø> (ø)
faer-cholesky/src/llt/solve.rs 34.57% <ø> (ø)
faer-cholesky/src/llt/update.rs 87.53% <ø> (ø)
faer-core/src/householder.rs 89.97% <ø> (ø)
... and 32 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarah-quinones sarah-quinones merged commit 0b5d090 into main Oct 13, 2023
4 of 5 checks passed
This was referenced Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants