Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #8

Closed
sarahtattersall opened this issue Oct 9, 2013 · 1 comment
Closed

Refactor #8

sarahtattersall opened this issue Oct 9, 2013 · 1 comment
Assignees

Comments

@sarahtattersall
Copy link
Owner

PIPE needs quite a lot of refactoring to improve readability

@ghost ghost assigned sarahtattersall Oct 9, 2013
sarahtattersall pushed a commit that referenced this issue Oct 9, 2013
* Split code chunks into smaller methods
* Initialise variables when declared
* Improve readability
sarahtattersall pushed a commit that referenced this issue Oct 9, 2013
 * References #8 and #5
 * Uses mockito to mock PetriNetView
 * Adds unit tests to check pasting of name
sarahtattersall pushed a commit that referenced this issue Oct 9, 2013
sarahtattersall pushed a commit that referenced this issue Oct 24, 2013
* Modified models to more closely represent XML values (including x,y,etc.)
* Create PNML Reader in package
* Implement new PNML in View
* Try and implement Arc start/end logic in arcview relying on model
  rather than graphical components
* Create tokens, so coloured ones show up
* THIS IMPLEMENTATION DOES NOT ACTUALLY WORK CORRECTLY YET
  IT JUST DISPLAYS CORRECTLY. NEEDS WORK BEFORE CAN ACTUALLY COMPUTE VALUES
  THAT IS NEED TO RELY ON MODELS RATHER THAN FUDGED VALUES
* Added tests for new reading
* References #8 #7
sarahtattersall pushed a commit that referenced this issue Jan 27, 2014
* Modified models to more closely represent XML values (including x,y,etc.)
* Create PNML Reader in package
* Implement new PNML in View
* Try and implement Arc start/end logic in arcview relying on model
  rather than graphical components
* Create tokens, so coloured ones show up
* THIS IMPLEMENTATION DOES NOT ACTUALLY WORK CORRECTLY YET
  IT JUST DISPLAYS CORRECTLY. NEEDS WORK BEFORE CAN ACTUALLY COMPUTE VALUES
  THAT IS NEED TO RELY ON MODELS RATHER THAN FUDGED VALUES
* Added tests for new reading
* References #8 #7
sarahtattersall pushed a commit that referenced this issue Feb 2, 2014
* Modified models to more closely represent XML values (including x,y,etc.)
* Create PNML Reader in package
* Implement new PNML in View
* Try and implement Arc start/end logic in arcview relying on model
  rather than graphical components
* Create tokens, so coloured ones show up
* THIS IMPLEMENTATION DOES NOT ACTUALLY WORK CORRECTLY YET
  IT JUST DISPLAYS CORRECTLY. NEEDS WORK BEFORE CAN ACTUALLY COMPUTE VALUES
  THAT IS NEED TO RELY ON MODELS RATHER THAN FUDGED VALUES
* Added tests for new reading
* References #8 #7
@sarahtattersall
Copy link
Owner Author

Refactoring largely done, model logic has been split out into pipe-core. Closing this issue in favour of more specific ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant