Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Properties" property missing from "run" object in schema #274

Open
mattjohnsonpint opened this issue Nov 15, 2016 · 4 comments
Open

"Properties" property missing from "run" object in schema #274

mattjohnsonpint opened this issue Nov 15, 2016 · 4 comments
Labels

Comments

@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Nov 15, 2016

Section 5.12.15 describes a properties property for the run object. This doesn't exist in the JSON Schema.

However, the run object contains an invocation property, and there is a properties property on that object that is described as "Key/value pairs that provide additional information about the run." in the schema description. That one should probably say "... about the invocation".

@ghost ghost added the bug label Sep 23, 2017
@ghost
Copy link

ghost commented Sep 23, 2017

@michaelcfanning FYI

Hi @mj1856, I don't know how this slipped through the cracks. You are right on both counts. We will fix this. Thanks!

@mattjohnsonpint
Copy link
Contributor Author

Any update on this? Thanks.

@ghost
Copy link

ghost commented Mar 13, 2018

@mj1856 @michaelcfanning

Hi Matt,

Yes, we fixed this. The reason you don't see any action in this repo is that the spec is now being standardized by OASIS, and the work is being tracked in an OASIS-managed repo: https://github.com/oasis-tcs/sarif-spec.

Both the spec and the schema now correctly mention run.properties. For now, you'll find the schema in the SARIF SDK repo:

https://github.com/Microsoft/sarif-sdk/blob/master/src/Sarif/Schemata/Sarif.schema.json

... but we will ultimately publish it as part of the OASIS spec.

Best regards,
Larry

@mattjohnsonpint
Copy link
Contributor Author

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant