add missing type hints for ItemPaged (Azure#24548)

* add missing type hints for ItemPaged * update changelog
sarkar-rajarshi · Jun 9, 2022 · 4f75bb2 · 4f75bb2
1 parent bc9d4c9
commit 4f75bb2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### Bugs Fixed
 
+- Fixed type hints for `azure.core.paging.ItemPaged` #24548
+
 ### Other Changes
 
 ## 1.24.0 (2022-05-06)

diff --git a/sdk/core/azure-core/azure/core/paging.py b/sdk/core/azure-core/azure/core/paging.py
@@ -102,8 +102,7 @@ def __init__(self, *args, **kwargs):
             "page_iterator_class", PageIterator
         )
 
-    def by_page(self, continuation_token=None):
-        # type: (Optional[str]) -> Iterator[Iterator[ReturnType]]
+    def by_page(self, continuation_token: Optional[str] = None) -> Iterator[Iterator[ReturnType]]:
         """Get an iterator of pages of objects, instead of an iterator of objects.
 
         :param str continuation_token:
@@ -123,7 +122,7 @@ def __iter__(self):
         """Return 'self'."""
         return self
 
-    def __next__(self):
+    def __next__(self) -> ReturnType:
         if self._page_iterator is None:
             self._page_iterator = itertools.chain.from_iterable(self.by_page())
         return next(self._page_iterator)