-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shows first semester GPA during second semester #126
Conversation
Can this be merged or do you want me to wait for #112 and use the classes from that instead? |
I've actually just been waiting for a review for that PR. Would you like to try reviewing it? EDIT: You know what, @insertcustomname, how would you rather do this? Should we just merge this one first? I can refactor to use the classes here as well in #112 so would you rather merge this one first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself looks good but you seem to have some .DS_Store
files in the commit as well as a merge from master. Could you rebase your branch on top of current master and get rid of the .DS_Store
files?
You're also welcome to put a copyright header in the file.
Thank you!
EDIT: Also, I'm worried about a race condition in which the request for the 1st semester grades finishes first and the semester 1 GPA is below the semester 2 GPA. You think we could move that to after the semester 2 GPA has been added to the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to prevent accidental merge. See above :)
I fixed the race condition, I tried adding the DS_store to the git ignore but not sure if it worked. |
|
Yeah that would be really helpful, thanks! |
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg> Signed-off-by: Gary Kim <gary@garykim.dev>
… of text parsing Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg> Signed-off-by: Gary Kim <gary@garykim.dev>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
d0a9c9f
to
df0a6d4
Compare
@insertcustomname What do you think? |
Great thanks, can we merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you
Closes #70
Uses fetch API to get grade history page and display first semester GPA during second semester.