Add Missing Indicator on the Main Page and Classes for Course and Assignment #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-kim
added
enhancement
gary-kim
force-pushed
the
enh/103/missing-indicator
branch
6 times, most recently
from
e3c0392
to
441ec19
Compare
gary-kim
changed the title
gary-kim
force-pushed
the
enh/103/missing-indicator
branch
6 times, most recently
from
5c3b376
to
fe51d2b
Compare
gary-kim
force-pushed
the
enh/103/missing-indicator
branch
4 times, most recently
from
80d27f0
to
708365a
Compare
|
@insertcustomname Do you want to take a look? This PR makes changes to what you added in #126 |
gary-kim
force-pushed
the
enh/103/missing-indicator
branch
from
708365a
to
2ddcc1a
Compare
Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
force-pushed
the
enh/103/missing-indicator
branch
from
2ddcc1a
to
86d2116
Compare
Closed
|
Ping, could this get a review? |
Suhas-13
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
This PR also includes a refactoring to use classes for
CourseandAssignmentThis adds a missing indicator on the main page so you can easily see if you have missing assignments for a course.
EDIT: Now, it also adds a tooltip that pops up when hovering over the grade that lists the missing assignments.
I was also thinking, should this come with some kind of toggle in case you don't want the indicators?
One more thing I was thinking of adding was storing how many assignments are missing so the user can acknowledge missing assignments so the indicator only shows up again if you are missing even more assignments. Not entirely sure how the UI or storage for that would work though.
It looks like this when you are missing an assignment:
