unnecessary plus one for :erlang.phash()

[nhooyr]

elixir-in-action/code_samples/ch09/proper_registry_supervision/lib/todo/database.ex

Line 21 in c6c0813

:erlang.phash2(key, @pool_size) + 1

:erlang.phash() already puts the number between 1..n, no need to add one.

[sasa1977]

The function used in the code is :erlang.phash2 (notice the trailing 2 in the name), which returns the result in the range of 0..(n-1) (see here), so +1 is needed in this case.

Thanks for submitting the issue anyway :-)

[nhooyr]

Oh, why not use :erlang.phash then?

[sasa1977]

The docs for phash2 state the following:

This BIF is always to be used for hashing terms. It distributes small integers better than phash/2, and it is faster for bignums and binaries.