New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interface of TokenTopicMatrix class #33

Closed

sashafrey opened this issue Mar 1, 2014 · 1 comment

Labels

Owner

sashafrey commented Mar 1, 2014

There are several troubles:

Class should be renamed to TopicModel.
TokenWeights should be iterator, and renamed to TopicWeightIterator
token_id() function should never return -1.

Owner Author

sashafrey commented Mar 1, 2014

Fix pushed to alfrey_refactor_token_topic_matrix branch

sashafrey closed this as completed

sashafrey added the refactoring label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment