Allow "!" in custom property values (#266)

Closes #260
sass · Mar 23, 2018 · 4c293f3 · 4c293f3
1 parent 5cc3238
commit 4c293f3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 1.0.0-rc.2
+
+* Allow `!` in custom property values ([#260][]).
+
+[#260]: https://github.com/sass/dart-sass/issues/260
+
 ## 1.0.0-rc.1
 
 * Add support for importing an `_index.scss` or `_index.sass` file when

diff --git a/lib/src/parse/parser.dart b/lib/src/parse/parser.dart
@@ -202,7 +202,7 @@ abstract class Parser {
     return buffer.toString();
   }
 
-  /// Consumes tokens until it reaches a top-level `":"`, `"!"`, `")"`, `"]"`,
+  /// Consumes tokens until it reaches a top-level `":"`, `")"`, `"]"`,
   /// or `"}"` and returns their contents as a string.
   @protected
   String declarationValue() {
@@ -270,7 +270,6 @@ abstract class Parser {
           wroteNewline = false;
           break;
 
-        case $exclamation:
         case $semicolon:
           if (brackets.isEmpty) break loop;
           buffer.writeCharCode(scanner.readChar());

diff --git a/lib/src/parse/stylesheet.dart b/lib/src/parse/stylesheet.dart
@@ -2309,7 +2309,7 @@ abstract class StylesheetParser extends Parser {
     return buffer.interpolation(scanner.spanFrom(start));
   }
 
-  /// Consumes tokens until it reaches a top-level `":"`, `"!"`, `")"`, `"]"`,
+  /// Consumes tokens until it reaches a top-level `":"`, `")"`, `"]"`,
   /// or `"}"` and returns their contents as a string.
   ///
   /// Unlike [declarationValue], this allows interpolation.
@@ -2392,7 +2392,6 @@ abstract class StylesheetParser extends Parser {
           wroteNewline = false;
           break;
 
-        case $exclamation:
         case $semicolon:
           if (brackets.isEmpty) break loop;
           buffer.writeCharCode(scanner.readChar());

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.0.0-rc.1
+version: 1.0.0-dev
 description: A Sass implementation in Dart.
 author: Dart Team <misc@dartlang.org>
 homepage: https://github.com/sass/dart-sass