-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error compiling bootstrap glyphicon, and font-awesome. #345
Comments
Can you provide a concrete example of Sass code that compiles as expected in Ruby Sass and not in Dart Sass? |
@nex3 The compiled css for glyphicons are correct. Take this little icon test repo: I hope that helps. |
I'm looking for a stand-alone reproduction: just plain Sass code, the CSS you expect to be generated, and the CSS that's actually generated. |
@nex3 the second repo: Very simple sass to css |
It's not standalone; it imports a file from bootstrap. |
I see, well I am not sure how else I could farther assist you. something is going wrong there that produces incorrect css by compiling a scss bootstrap file. The above example show you how to reproduce it without doing anything fancy. meanwhile i moved to another structure to workaround the problem. If you have any question I will be happy to answer. |
I'm going to close this pending a standalone test case. |
@nex3 https://github.com/yanivkalfa/icon-test i've made it even simpler - now i am just take the string I hope that's specific enough to take a look at. |
@nex3 const sass = require('sass');
const result = sass.renderSync({ data: '.glyphicon-arrow-left { &:before { content: "\e091"; } }' });
console.log(result.css.toString()); - will produce the right output. However const result = sass.renderSync({ file: path_to_file });
console.log(result.css.toString()); Will not. |
Dart Sass does compile CSS escapes to literal Unicode values--that is, it generates Your |
@nex3 I was using Chromium 61.0.3163.1. haven't tested any other browsers. either way. thanks for responding and good luck with the project. |
This pen uses both an escape code and a literal Unicode character, and renders two identical snowmen for me on Chrome 67.0.3396.79 and Firefox 52.6.0. |
is there anyway to force uft-8 output? |
@N6REJ I'm not sure what you mean by that. Sass always emits UTF-8. |
@nex3 sorry it does not..
if you run ruby based sass on scss you'll get unicode output, if you run js npm-sass you'll get utf-8 |
I'm not sure what the difference between "unicode output" and "utf-8" is, and I don't know whether "js npm-sass" refers to the |
ok, I"m probably confusing us both since This is my first time trying to use scss.... |
What you're looking for is an escape code rather than a UTF-8 character. #568 tracks adding a flag to force all non-ASCII characters to be emitted as escape codes. |
Thats not what you stated here. Please stop giving me the run around. |
@N6REJ Please follow the Sass community guidelines. In particular, please assume good intentions from people you interact with. It's not appropriate to accuse me of "giving [you] the run around". |
I am trying to compile bootstrap-sass or font-awesome-sass to normal css. The fonts are being added correctly however the '::after -> content ' attribute is messaged up completely.
To check that its not on my end, I took the content of a working icon, and pasted it instead of the content that your compiler produced and it works fine.
The text was updated successfully, but these errors were encountered: