Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.3.3 #1808

Closed
6 tasks done
xzyfer opened this issue Dec 28, 2015 · 13 comments
Closed
6 tasks done

Release 3.3.3 #1808

xzyfer opened this issue Dec 28, 2015 · 13 comments
Assignees
Milestone

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Dec 28, 2015

This issues tracks the 3.3.3 release. Subscribe to this if you are waiting for a fix in that version.

  • Applaud @mgreter 👏 👏 👏 👏
  • Make sure we don't break eyeglass /cc @chriseppstein
  • Make sure we've fixed sassdash /cc @davidkpiano
  • Release notes
  • Release SassC
  • Release LibSass
@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 13, 2016

Added a release todo list /cc @mgreter @saper

@opeologist
Copy link

/applauds @mgreter 👏 👏 👏 👏 ^_^

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 14, 2016

@mgreter @saper I've confirmed both eyeglass and sassdash have fully passing test suites with node-sass compiled against @a559139.

I'm happy to call this release ready and start cutting release notes. Objections?

@mgreter
Copy link
Contributor

mgreter commented Jan 14, 2016

Not really, 3.3.4 might follow shortly after (need to wait for 3.4 before all API changes are ready).

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 14, 2016

Tying up some loose ends on the node-sass side of things. I'll tag the release in the next 48hrs.

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 18, 2016

@mgreter we need to feature freeze before I can cut the release. Let me know when you're done.

@mgreter
Copy link
Contributor

mgreter commented Jan 18, 2016

@xzyfer I thought you would first prepare the notes? Waiting for these, then we can freeze.

@mgreter
Copy link
Contributor

mgreter commented Jan 20, 2016

Went ahead and created them via:

use strict;
use warnings;

use pQuery;

my $loop = 1;
my $page = 0;
my $count = 0;
my $tag = "3.3.3";

while ($loop) {

  $loop = 0;
  $page ++;

  pQuery("http://github.com/sass/libsass/issues?page=$page&q=milestone%3A$tag+is%3Aclosed")
    ->find('LI[id^="issue_"]')
    ->each(sub {
        $loop = 1;
        $count ++;
        my $i = shift;
        my $doc = pQuery($_);
        my $title = $doc->find('.issue-title-link')->text;
        my $user = $doc->find('.table-list-cell-avatar IMG')->attr('alt');
        my $id = $doc->attr('id');
        $id = $1 if $id =~ m/issue_(\d+)/;
        print "- ", $title, " (", ($user ? $user : "XXX"), ", #$id)\n";

    });

}

@mgreter
Copy link
Contributor

mgreter commented Jan 22, 2016

@xzyfer can you release and test sassc? I will not have time this weekend!

@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 22, 2016

Will do. I need to spend some time getting my node sass releases working again also.

@mgreter
Copy link
Contributor

mgreter commented Feb 23, 2016

Any progress here?

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 11, 2016

Released SassC 3.3.3

@xzyfer xzyfer closed this as completed Mar 11, 2016
@saper
Copy link
Member

saper commented Mar 11, 2016

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants