Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault with specific @media and @at-root combinations #859

Closed
anlutro opened this issue Jan 27, 2015 · 7 comments · Fixed by #861
Closed

Segmentation fault with specific @media and @at-root combinations #859

anlutro opened this issue Jan 27, 2015 · 7 comments · Fixed by #861

Comments

@anlutro
Copy link
Contributor

anlutro commented Jan 27, 2015

I'm using sassc (compiled from master today) and ran across a segmentation fault with a specific combination of @media, selectors and @at-root.

This is the minimal code I've been able to reproduce the segmentation fault in.

@media screen
    .two
        @at-root .one
            background: blue
            .three
                color: red
$ sassc ./test.sass 
Segmentation fault

Removing any bit of this example makes it compile just fine - it's something about the combination of rules (background: blue) and selectors (.three) within the @at-root declaration that's messing up.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 28, 2015

I've confirmed this is an issue on the latest master

@media screen {
  .two {
    @at-root .one {
      background: blue;
      .three {
        color: red;
      }
    }
  }
}

@xzyfer xzyfer self-assigned this Jan 28, 2015
@xzyfer xzyfer added this to the 3.2 milestone Jan 28, 2015
@KittyGiraudel
Copy link

@xzyfer Does this mean I missed a case with my @at-root test suite?

@xzyfer
Copy link
Contributor

xzyfer commented Jan 28, 2015

It would appear so.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 29, 2015

I've got a fix #861.

I don't have time to create the spec now, but when I do this is ready to go.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 30, 2015

Spec added sass/sass-spec#248

@xzyfer
Copy link
Contributor

xzyfer commented Jan 30, 2015

This is fixed and will be 3.2.

@anlutro
Copy link
Contributor Author

anlutro commented Jan 30, 2015

Awesome. I love using sassc, keep up the great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants