Skip to content

Commit

Permalink
Remove skip download for CI flag
Browse files Browse the repository at this point in the history
This flag means we skip a bunch of code paths in CI which is not
ideal. Since we tell people to use `npm rebuild` we should eat our
own dog food.

With this patch we do an install, then do a rebuild hitting all the
major install code paths.

Fixes #1453
  • Loading branch information
xzyfer committed Nov 7, 2019
1 parent 910527c commit 6b85be8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
9 changes: 9 additions & 0 deletions .travis.yml
Expand Up @@ -2,6 +2,7 @@ language: node_js

compiler: gcc

<<<<<<< HEAD
env:
global:
- SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=true
Expand All @@ -21,6 +22,13 @@ jobs:
os: linux
- stage: platform-test
node_js: "10"
=======
matrix:
fast_finish: true
exclude:
- node_js: iojs
- node_js: "0.10"
>>>>>>> 7110e43d... Remove skip download for CI flag
os: osx
- stage: platform-test
node_js: "13"
Expand Down Expand Up @@ -65,6 +73,7 @@ install:
- npm install

script:
- npm run build
- npm test

cache:
Expand Down
4 changes: 2 additions & 2 deletions appveyor.yml
Expand Up @@ -32,7 +32,6 @@
- '%AppData%\npm-cache'

environment:
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
matrix:
- nodejs_version: 10
GYP_MSVS_VERSION: 2017
Expand All @@ -50,6 +49,7 @@
- node --version
- npm --version
- npm install
- npm run build

test: off

Expand Down Expand Up @@ -108,7 +108,6 @@
- '%AppData%\npm-cache'

environment:
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
matrix:
- nodejs_version: 10
GYP_MSVS_VERSION: 2017
Expand All @@ -126,6 +125,7 @@
- node --version
- npm --version
- npm install
- npm run build

test_script:
- ps: set-location -path c:\projects\node_modules\node-sass
Expand Down

0 comments on commit 6b85be8

Please sign in to comment.