Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

release as 1.0.0 #439

Closed
dylang opened this issue Sep 27, 2014 · 12 comments
Closed

release as 1.0.0 #439

dylang opened this issue Sep 27, 2014 · 12 comments

Comments

@dylang
Copy link
Contributor

dylang commented Sep 27, 2014

npm 2.0.0 is out and it follows semver a bit more strickly, namely using ~version and ^version won't include pre-releases (ie: the version has a hyphen such as x.y.z-rc1).

It would also be helpful to bump to 1.0.0 because 0.y.z versions don't necessarily follow semver (major.feature.patch), making it difficult to know if new releases are breaking the API, adding new features, or just bug fixes.

@nschonni
Copy link
Contributor

1.0.0 indicates you've reached a stable API version. There is still a fair amount of churn and critical bugs (mainly @extend) in the underlaying libsass library so it's not appropriate yet.

@keithamus
Copy link
Member

While I don't disagree with @nschonni - I'll play devils advocate and suggest that since its on NPM and users are consuming it, it should be 1.0.0. From the semver.org site:

How do I know when to release 1.0.0?

If your software is being used in production, it should probably already be 1.0.0. If you have a stable API on which users have come to depend, you should be 1.0.0. If you're worrying a lot about backwards compatibility, you should probably already be 1.0.0.

Also, our upstream dependency - libsass - is already on 2.1.0.

@andrew
Copy link
Contributor

andrew commented Sep 30, 2014

I think it makes sense to go towards 1.0.0 but node-sass isn't without a number of issues that keep getting reported. Going to 1.0.0 now would be a signal that it's ok to use now which isn't really the case yet without some big caveats.

@tomByrer
Copy link

tomByrer commented Oct 2, 2014

some big caveats

Exactly what are the 1.0.0 blockers please?

A (SemVer) v1.0.0 doesn't have to be prefect, just the API can't be changing every other week. However, the API can still change; that would become v2.0.0
BTW, isaacs gave up on expecting v1.0.0 to be the first public release, effectively making his node-semver script not fully compatible with SemVer v2 spec.

@andrew
Copy link
Contributor

andrew commented Oct 4, 2014

I think it makes sense to release v1.0.0 along with the libsass 3.0 update as the next major release.

@keithamus keithamus mentioned this issue Oct 9, 2014
@andrew
Copy link
Contributor

andrew commented Oct 16, 2014

3.0 has been released, let's get that out as 1.0.0 along with removing the middleware as a dependency: https://github.com/sass/libsass/releases/tag/3.0

@am11
Copy link
Contributor

am11 commented Oct 16, 2014

@andrew, so we don't need to update the code here in current master. Only update the submodules (libsass and sass-specs) and then publish binaries to node-sass-binaries?

@andrew
Copy link
Contributor

andrew commented Oct 16, 2014

As far as I can tell from my phone, yes

@am11
Copy link
Contributor

am11 commented Oct 16, 2014

@andrew, I have pushed windows binaries and the PR is awaiting here for latest submodules.

@keithamus would you take care of Mac and Linux so we can :shipit: ? 8-)

@andrew
Copy link
Contributor

andrew commented Oct 16, 2014

@andrew andrew closed this as completed Oct 16, 2014
@keithamus
Copy link
Member

@am11 Sorry I missed this! 😢

@tomByrer
Copy link

🎆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants