-
Notifications
You must be signed in to change notification settings - Fork 1.3k
release as 1.0.0 #439
Comments
1.0.0 indicates you've reached a stable API version. There is still a fair amount of churn and critical bugs (mainly |
While I don't disagree with @nschonni - I'll play devils advocate and suggest that since its on NPM and users are consuming it, it should be 1.0.0. From the semver.org site:
Also, our upstream dependency - libsass - is already on |
I think it makes sense to go towards 1.0.0 but node-sass isn't without a number of issues that keep getting reported. Going to 1.0.0 now would be a signal that it's ok to use now which isn't really the case yet without some big caveats. |
Exactly what are the 1.0.0 blockers please? A (SemVer) v1.0.0 doesn't have to be prefect, just the API can't be changing every other week. However, the API can still change; that would become v2.0.0 |
I think it makes sense to release v1.0.0 along with the libsass 3.0 update as the next major release. |
3.0 has been released, let's get that out as 1.0.0 along with removing the middleware as a dependency: https://github.com/sass/libsass/releases/tag/3.0 |
@andrew, so we don't need to update the code here in current master. Only update the submodules (libsass and sass-specs) and then publish binaries to node-sass-binaries? |
As far as I can tell from my phone, yes |
@andrew, I have pushed windows binaries and the PR is awaiting here for latest submodules. @keithamus would you take care of Mac and Linux so we can ? 8-) |
@am11 Sorry I missed this! 😢 |
🎆 |
npm 2.0.0
is out and it follows semver a bit more strickly, namely using~version
and^version
won't include pre-releases (ie: the version has a hyphen such asx.y.z-rc1
).It would also be helpful to bump to
1.0.0
because0.y.z
versions don't necessarily follow semver (major.feature.patch
), making it difficult to know if new releases are breaking the API, adding new features, or just bug fixes.The text was updated successfully, but these errors were encountered: