Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Fix race conditons in watcher tests #1150

Merged
merged 1 commit into from
Sep 16, 2015
Merged

Fix race conditons in watcher tests #1150

merged 1 commit into from
Sep 16, 2015

Conversation

saper
Copy link
Member

@saper saper commented Sep 16, 2015

We are getting test failures:

  1. cli node-sass in.scss should watch the full scss dep tree for a single file:
  Uncaught AssertionError: false == true

  + expected - actual

  -false

  +true

  at Socket.<anonymous> (test/cli.js:317:9)
  at readableAddChunk (_stream_readable.js:146:16)
  at Socket.Readable.push (_stream_readable.js:110:10)
  at Pipe.onread (net.js:523:20)

@saper saper changed the title should watch the full scss dep tree: fix race Fix race conditons in watcher tests Sep 16, 2015
@saper saper force-pushed the racedeptree branch 2 times, most recently from 465ce9c to 28c22e5 Compare September 16, 2015 20:52
@saper
Copy link
Member Author

saper commented Sep 16, 2015

41 passing (19s)
1 pending
1 failing

  1. cli node-sass in.scss should watch the full sass dep tree for a single file (sass):
  Uncaught AssertionError: 'body{background:white}\n\nbody{background:white}' == 'body{background:white}'
  + expected - actual

  -body{background:white}
  -
   body{background:white}

We are getting test failures:

1) cli node-sass in.scss should watch the full scss dep tree for a single file:

      Uncaught AssertionError: false == true

      + expected - actual

      -false

      +true

      at Socket.<anonymous> (test/cli.js:317:9)
      at readableAddChunk (_stream_readable.js:146:16)
      at Socket.Readable.push (_stream_readable.js:110:10)
      at Pipe.onread (net.js:523:20)
@xzyfer
Copy link
Contributor

xzyfer commented Sep 16, 2015

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants