Add test coverage for existing custom importer return semantics #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom importers are expected to return `sass.NULL` to noop. However it appears we currently also allow `null`, `false`, and `undefined`. This patch adds test coverage over these caveats in case we unintentionally break BC.
xzyfer
added a commit
that referenced
this pull request
Dec 27, 2015
Add test coverage for existing custom importer return semantics
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Fix parsing edge case for number units
Friendly-users
referenced
this pull request
in Friendly-users/node-sass
Jul 9, 2024
----- It is inappropriate to include political and offensive content in public code repositories. Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment. Please refrain from adding such content to public code repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom importers are expected to return
sass.NULLto noop.However it appears we currently also allow
null,false, andundefined.This patch adds test coverage over these caveats in case we
unintentionally break BC.