Merge pull request #1319 from xzyfer/test/import-null

Add test coverage for existing custom importer return semantics
sass · Dec 27, 2015 · 31d54cb · 31d54cb
2 parents 08f1189 + 7a060a7
commit 31d54cb
Show file tree

Hide file tree

Showing 3 changed files with 95 additions and 6 deletions.
diff --git a/test/api.js b/test/api.js
@@ -278,7 +278,7 @@ describe('api', function() {
           });
         }
       }, function(error, result) {
-        assert.equal(result.css.toString().trim(), '');
+        assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
         done();
       });
     });
@@ -292,7 +292,7 @@ describe('api', function() {
           });
         }
       }, function(error, result) {
-        assert.equal(result.css.toString().trim(), '');
+        assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
         done();
       });
     });
@@ -306,7 +306,7 @@ describe('api', function() {
           };
         }
       }, function(error, result) {
-        assert.equal(result.css.toString().trim(), '');
+        assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
         done();
       });
     });
@@ -320,7 +320,44 @@ describe('api', function() {
           };
         }
       }, function(error, result) {
-        assert.equal(result.css.toString().trim(), '');
+        assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
+        done();
+      });
+    });
+
+
+    it('should fallback to default import behaviour if importer returns null for backwards compatibility', function(done) {
+      sass.render({
+        file: fixture('include-files/index.scss'),
+        importer: function(url, prev, done) {
+          done(null);
+        }
+      }, function(error, result) {
+        assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
+        done();
+      });
+    });
+
+    it('should fallback to default import behaviour if importer returns undefined for backwards compatibility', function(done) {
+      sass.render({
+        file: fixture('include-files/index.scss'),
+        importer: function(url, prev, done) {
+          done(undefined);
+        }
+      }, function(error, result) {
+        assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
+        done();
+      });
+    });
+
+    it('should fallback to default import behaviour if importer returns false for backwards compatibility', function(done) {
+      sass.render({
+        file: fixture('include-files/index.scss'),
+        importer: function(url, prev, done) {
+          done(false);
+        }
+      }, function(error, result) {
+        assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
         done();
       });
     });
@@ -1248,7 +1285,7 @@ describe('api', function() {
         }
       });
 
-      assert.equal(result.css.toString().trim(), '');
+      assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
       done();
     });
 
@@ -1262,7 +1299,7 @@ describe('api', function() {
         }
       });
 
-      assert.equal(result.css.toString().trim(), '');
+      assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
       done();
     });
 
@@ -1294,6 +1331,56 @@ describe('api', function() {
       done();
     });
 
+
+
+    it('should fallback to default import behaviour if importer returns sass.NULL', function(done) {
+      var result = sass.renderSync({
+        file: fixture('include-files/index.scss'),
+        importer: function() {
+          return sass.NULL;
+        }
+      });
+
+      assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
+      done();
+    });
+
+    it('should fallback to default import behaviour if importer returns null for backwards compatibility', function(done) {
+      var result = sass.renderSync({
+        file: fixture('include-files/index.scss'),
+        importer: function() {
+          return null;
+        }
+      });
+
+      assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
+      done();
+    });
+
+    it('should fallback to default import behaviour if importer returns undefined for backwards compatibility', function(done) {
+      var result = sass.renderSync({
+        file: fixture('include-files/index.scss'),
+        importer: function() {
+          return undefined;
+        }
+      });
+
+      assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
+      done();
+    });
+
+    it('should fallback to default import behaviour if importer returns false for backwards compatibility', function(done) {
+      var result = sass.renderSync({
+        file: fixture('include-files/index.scss'),
+        importer: function() {
+          return false;
+        }
+      });
+
+      assert.equal(result.css.toString().trim(), '/* foo.scss */\n/* bar.scss */');
+      done();
+    });
+
     it('should accept arrays of importers and return respect the order', function(done) {
       var result = sass.renderSync({
         file: fixture('include-files/index.scss'),

diff --git a/test/fixtures/include-files/bar.scss b/test/fixtures/include-files/bar.scss
@@ -0,0 +1 @@
+/* bar.scss */
diff --git a/test/fixtures/include-files/foo.scss b/test/fixtures/include-files/foo.scss
@@ -0,0 +1 @@
+/* foo.scss */