Bump LibSass to 3.5.5 #2543
Merged
Bump LibSass to 3.5.5 #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: src/libsass git-subtree-split: 39e3087
nschonni
reviewed
Nov 11, 2018
| @@ -47,7 +47,7 @@ int base64_encode_block(const char* plaintext_in, int length_in, char* code_out, | |||
| *codechar++ = base64_encode_value(result); | |||
| result = (fragment & 0x003) << 4; | |||
| #ifndef _MSC_VER | |||
| __attribute__ ((fallthrough)); | |||
| /* fall through */ | |||
There was a problem hiding this comment.
This is an upstream thing, but it seems odd to have a compiler directive for only a comment now
| @@ -126,12 +121,11 @@ namespace Sass { | |||
|
|
|||
| namespace File { | |||
|
|
|||
| static std::vector<std::string> defaultExtensions = { ".scss", ".sass" }; | |||
| static std::vector<std::string> defaultExtensions = { ".scss", ".sass", ".css" }; | |||
There was a problem hiding this comment.
This seems off, is this the think where libsass was treating plain CSS as SCSS?
There was a problem hiding this comment.
This is the revert of the CSS import deprecation warning as discussed in #2362
|
This LibSass version bump in specifically to resolve #2362 so it needs to land in v4. |
nschonni
approved these changes
Nov 12, 2018
|
Is this a complete revert of the CSS importing behavior or are there minor changes on how it works behind the scenes? |
|
This is a revert to the previous behaviour. There will be changes soon in
order to match the newly spec'd behaviour
…On Thu., 15 Nov. 2018, 5:09 am Ranie Santos ***@***.*** wrote:
Is this a complete revert of the CSS importing behavior or are there minor
changes on how it works behind the scenes?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2543 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWPCAY6TBRSSMO8aa8KtwaIFHW_8aks5uvFx1gaJpZM4YYVlc>
.
|
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
…indicator Make error indicator Unicode aware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/libsasswith a git subtreeFixes #2362