fix: Flatten sourceMap folder detection #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 067ae70 into 0d6c3cc - view on LGTM.com fixed alerts:
|
|
@xzyfer trying out CodeQL/LGTM.com, but this was the only thing it found right now. There are some things on the libsass side, but I'll open an issue over there |
|
Is the same possible without inlining the condition? The variable name was useful in conveying the intent. I think that's valuable given the messy state of the sourcemapa logic. |
|
It is, but then it's evaluating the directory aspect even in the "happy path". Alternately, I could move it inside the final |
CodeQL was flagging the second `else if`.
nschonni
force-pushed
the
lgtm-warning-unused-condition
branch
from
067ae70
to
889a2fc
Compare
|
OK, moved it into the inner |
Friendly-users
referenced
this pull request
in Friendly-users/node-sass
Jul 9, 2024
----- It is inappropriate to include political and offensive content in public code repositories. Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment. Please refrain from adding such content to public code repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL was flagging the second
else if.Looked at code and inlined the single use so it's not executed if
first condition is true.