Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misbehaving link #704

Closed
ericmutta opened this issue Mar 18, 2023 · 4 comments · Fixed by #706
Closed

Misbehaving link #704

ericmutta opened this issue Mar 18, 2023 · 4 comments · Fixed by #706
Assignees

Comments

@ericmutta
Copy link
Contributor

The following link:

https://sass-lang.com/documentation/breaking-changes/random-with-units

...which is found under the breaking changes section here:

image

...doesn't work as expected. The HTTP response comes back with a content-type header value of application/octet-stream which means the browser opens a File Download dialog rather than loading the page:

image

@Goodwine
Copy link
Member

Interesting, somehow the document/file for random-with-units got deleted 🤔 🤔

@Goodwine
Copy link
Member

Possible culprit - #683, it seems that it was intended to remove it but make it a redirect link

@Goodwine
Copy link
Member

Reading on https://www.jvt.me/posts/2021/10/28/middleman-redirect-content-type/

It seems like Middleman considers the URL path to determine the content-type, where no content-type seems to default to application/octet-stream. In this case we can simple add a dummy .html extension at the end. I'll send a PR about it.

FWIW this also affects the url d/color-units

@ericmutta
Copy link
Contributor Author

Many thanks @Goodwine and @nex3 for following up on this (and for the great work on SASS which I switched to immediately after seeing how much more powerful it is compared to LESS 💪 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants