Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to set syntax passed to gonzales via CLI --syntax option #381

Closed
donabrams opened this issue Nov 9, 2015 · 3 comments
Closed

Comments

@donabrams
Copy link
Contributor

As per skovhus/SublimeLinter-contrib-sass-lint#4, we have a need to override the syntax and not use the file-detected syntax based on extension.

Expected: sass-lint --syntax scss a.txt will use scss syntax and sass-lint --syntax sass a.txt will use sass syntax.

Naive implementation here (since PRs must wait...): develop...donabrams:develop

@DanPurdy
Copy link
Member

HI @donabrams I had a read through your issue here it does seem like a very odd thing for sublimelinter to be changing the syntax of a file when it gets saved as a tmp file, have you filed an issue with them?

As for our end of it I can't really classify it as a bug as it's treating a .sass file as Sass syntax which is correct but I do see that this option would solve your needs and may also account for a few other strange errors we've seen mentioned recently (assuming now that they must of come from the sublime plugin!).

I'm going to ping @Snugug into the conversation here to check this over from a 'do we want/need this behaviour' but I'd be happy for you to submit that PR to our develop branch for consideration.

Initial thoughts on your changes would be just to make sure you add the option to the CLI docs too.

Thanks again!

@Snugug
Copy link
Member

Snugug commented Nov 10, 2015

This is tough as it'll solve your problem, but has a very real potential to be weird for globbed results. That being said, I can also see how it could be useful for other use cases like a pipeline that relies on file extensions for processing (Rails does this I believe?). Oh the castles we build on sand!

Anyway, yah, sure, issue a PR. There's no harm in having it as a CLI option if it'll solve your problem and doesn't break anything else. I'd also file a bug with SublimeLinter cause, like @DanPurdy said, that sounds like a crappy bug on their end.

@DanPurdy
Copy link
Member

This should of been closed a while ago as it's been a feature for a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants