Enhancement: Bang whitespace rules should consider !default flag

[bgriffith]

Currently the Space Before Bang and Space After Bang rules only consider the !important flag. It should consider the !default flag too.

[Snugug]

And !global

On Aug 30, 2015, at 7:06 PM, Ben Griffith notifications@github.com wrote:

Currently the Space Before Bang and Space After Bang rules only consider the !important flag. It should consider the !default flag too.

—
Reply to this email directly or view it on GitHub.

[bgriffith]

Got default flags working fine, but as soon as I use a global flag I get a parse error:

Parsing error at /Users/ben/workspace/sass-lint/tests/sass/space-after-bang.scss: Please check validity of the block starting from line #32
  Error: Parsing error at tests/sass/space-after-bang.scss: Please check validity of the block starting from line #32
      at module.exports (lib/groot.js:21:11)
      at Function.sassLint.lintText (index.js:23:13)
      at index.js:73:21
      at Array.forEach (native)
      at Function.sassLint.lintFiles (index.js:72:9)
      at lintFile (tests/main.js:10:22)
      at Context.<anonymous> (tests/main.js:297:5)

[Snugug]

I think we may need to wait until the next version of Gonzales is released to fully support !global

On Aug 30, 2015, at 7:19 PM, Ben Griffith notifications@github.com wrote:

Got default flags working fine, but as soon as I use a global flag I get a parse error:

Parsing error at /Users/ben/workspace/sass-lint/tests/sass/space-after-bang.scss: Please check validity of the block starting from line #32
Error: Parsing error at tests/sass/space-after-bang.scss: Please check validity of the block starting from line #32
at module.exports (lib/groot.js:21:11)
at Function.sassLint.lintText (index.js:23:13)
at index.js:73:21
at Array.forEach (native)
at Function.sassLint.lintFiles (index.js:72:9)
at lintFile (tests/main.js:10:22)
at Context. (tests/main.js:297:5)

—
Reply to this email directly or view it on GitHub.

[bgriffith]

Yeah I came to the same conclusion. I'll create a PR for the defaults.

[JohnAlbin]

So the linter fails when it sees !global? I'm going to open a new issue to track that critical bug. I want to use sass-lint, but can't while that bug is unfixed.