Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix develop - Silence output on no errors #171

Merged
merged 7 commits into from
Sep 19, 2015

Conversation

DanPurdy
Copy link
Member

Please merge #170 first, also see #170 for the description of why the tests are failing here.

Silences error output when no warnings or errors are present in linted files. Also improves the handling of writing output to the file system with completion/error messages but no error thrown.

closes #141

DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com

@DanPurdy
Copy link
Member Author

Will close for the time being.

@DanPurdy DanPurdy closed this Sep 14, 2015
@DanPurdy DanPurdy reopened this Sep 15, 2015
@DanPurdy
Copy link
Member Author

Don't know why i ended up opening this again.. Should remain closed until the master hotfix is merged

@DanPurdy DanPurdy closed this Sep 15, 2015
@bgriffith
Copy link
Member

Update this and I'll merge.

@DanPurdy
Copy link
Member Author

I know what the errors will be here, it's a consequence of merging in the silence output on no errors work in #171 and #170 will update later on.

@DanPurdy DanPurdy modified the milestones: 1.3.0, 1.2.1 Sep 18, 2015
@Snugug
Copy link
Member

Snugug commented Sep 19, 2015

This all looks good to me, just need the merge conflict resolved

The cli tests were failing as no errors were being generated due to this change, thus there was no output to be tested!
@DanPurdy
Copy link
Member Author

@Snugug @bgriffith it's good to go.

bgriffith added a commit that referenced this pull request Sep 19, 2015
Hotfix develop - Silence output on no errors
@bgriffith bgriffith merged commit 7e7c076 into sasstools:develop Sep 19, 2015
@DanPurdy DanPurdy deleted the hotfix/silence-output branch October 20, 2015 23:20
donabrams pushed a commit to donabrams/sass-lint that referenced this pull request Nov 19, 2015
Hotfix develop - Silence output on no errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputResults should only do so if warnings or error present
3 participants