Add retry button to submission error view #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
force-pushed
the
feature/1208-add-retry-button-to-submission-error-view
branch
from
3939526
to
141916d
Compare
andywer
deleted the
feature/1208-add-retry-button-to-submission-error-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue of submission timeouts was not related to horizon but to the timeout specified for the promise queue here. That's why the transaction often went through although the "An unknown error occured" message was shown.
Instead of increasing this timeout I changed the error message shown in the submission progress so that the error translation is used if
error.responseis undefined (i.e. the error is not a submission error).This means that a "Request timed out" message (i18n translation for
timeout-error) is shown once the timeout of 10 seconds is reached on transaction submission. If the user clicks on the newly added "Retry" button he is likely to see a "Successful" message pretty fast since the transaction was already accepted by the network.Closes #1208.