Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly incorrect error handling in edi.go/writeFile() #3

Closed
FrankRuben opened this issue Aug 7, 2014 · 3 comments
Closed

Possibly incorrect error handling in edi.go/writeFile() #3

FrankRuben opened this issue Aug 7, 2014 · 3 comments

Comments

@FrankRuben
Copy link

Hi,
I don't know what Assert() does, but assuming that it does not (always) return data, if an error occured, it would currently still write empty/incorrect data, since the function continues after the error has been logged.
HTH and regards, Frank

@0xAX
Copy link

0xAX commented Aug 7, 2014

Hello all,

+1 to @FrankRuben

Also what is it Asset()? I'm getting error that: undefined Asset

@ciarand
Copy link

ciarand commented Aug 7, 2014

Yeah, looks like the problem is here:

edi/edi.go

Line 38 in d0acb64

data, err := Asset(file)

The Asset func is undefined. Maybe something got missed in the initial release?

@satran
Copy link
Owner

satran commented Aug 7, 2014

I am using go-bindata to package all the js files in go so that the binary is one single file. The INSTALL.sh creates a bindata.go which contains the Asset function.

@satran satran closed this as completed Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants