Major modifications: Addition of ContentProvider and column name changed from id to _id. #556

bpappin · 2016-03-30T21:13:28Z

These are some major modifications in order to support several new features, most important among them, a new ContentProvider, so you can work with CursorLoader and the CursorAdapters.

This code is not compatible with version 1.5 of Sugar, mainly because the id column has been changed to _id as defined in android.provider.BaseColumns._ID (should have been like that from the start IMO) and I don't expect it to be merged.

At this point I am just making sure I share the code back to the project.

…epository.

…arORM.

…t simply drops tables and recreates them.

…ata tags to avoid conflicts with other libraries.

mention-bot · 2016-03-30T21:13:35Z

By analyzing the blame information on this pull request, we identified @whoshuu, @sibeliusseraphini and @pguedes to be potential reviewers

sibelius · 2016-03-30T21:16:16Z

I will take a look tomorrow, thanks

coveralls · 2016-03-30T21:21:58Z

Coverage decreased (-2.04%) to 65.448% when pulling c7c8e71 on bpappin:master into 619b5db on satyan:master.

pguedes · 2016-03-30T22:48:01Z

Ok. Will try to have a look when i can...

Enviado do meu iPad

No dia 30/03/2016, às 22:13, Mention Bot notifications@github.com escreveu:

By analyzing the blame information on this pull request, we identified @whoshuu, @sibeliusseraphini and @pguedes to be potential reviewers

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

sibelius · 2016-03-31T16:19:41Z

library/build.gradle

@@ -1,6 +1,14 @@
 apply plugin: 'com.android.library'
 apply from: '../maven_push.gradle'

+// https://docs.gradle.org/current/userguide/publishing_maven.html
+// http://www.flexlabs.org/2013/06/using-local-aar-android-library-packages-in-gradle-builds
+apply plugin: 'maven-publish'


@bpappin using maven-publish plugin, we can remove maven_push.gradle right?

cc @satyan

sibelius · 2016-03-31T19:23:50Z

@bpappin it looks like you are using tabs instead of space, could you fix this?

You did a great job on this PR thanks, I will make a few comments on your code, so we can accept this

We can add this to Sugar 2.0 release

Let me know if you want to help on more features like these ones (#540)

sibelius · 2016-03-31T19:35:20Z

could you also put in the Sugar example how to use the SugarContentProvider?

And maybe add some docs?

If you have any questions you could chat with me here: https://gitter.im/satyan/sugar or https://gitter.im/sibeliusseraphini or twitter

bpappin · 2016-04-01T00:05:01Z

I'm not sure how to fix the tabs, I always use tabs, so my editors are configured for them.

sibelius · 2016-04-01T00:22:42Z

I'm sure that every editor has the option to change tabs for spaces, don't you use android studio?

…le schema generator.

bpappin · 2016-04-01T01:01:15Z

I do, i just have no idea how to switch it, as it's never been an issue with modern editors, compilers or languages :)

Which class specifically needs to be fixed? I was trying not to get the editor to change them, so hopefully it's not every file.

bpappin · 2016-04-01T01:02:45Z

By the way, feel free to edit as you see fit, I will not be offended.
There are other things I want to do to it, so I'm going to remain on my own fork for a while.

# Conflicts: # library/src/main/java/com/orm/SchemaGenerator.java # library/src/main/java/com/orm/SugarContext.java # library/src/test/java/com/orm/SchemaGeneratorTest.java # sugar.iml

bpappin · 2016-04-02T23:08:16Z

I've just merged your master into my master, so the pull request should be in sync again.

sibelius · 2016-04-02T23:11:39Z

@bpappin do you have an idea or some code of how to migrate a production app using id with Sugar 1.5 to Sugar 2.0 using _id?

coveralls · 2016-04-02T23:14:17Z

Coverage decreased (-2.2%) to 68.185% when pulling 1cf0280 on bpappin:master into 5007b36 on satyan:master.

coveralls · 2016-04-03T00:44:27Z

Coverage decreased (-2.0%) to 68.441% when pulling b294404 on bpappin:master into 5007b36 on satyan:master.

sibelius · 2016-04-03T00:47:22Z

Do you think that a migration script could fix this?

bpappin · 2016-04-03T19:39:21Z

I don't know, someone is going to have to test it.
I suspect it could, but I've never tried to alter an id column in an sqlite table.

JonatanSalas · 2016-04-07T11:02:02Z

Could you solve the conflicts?

… changes to work around it.

bpappin · 2016-04-11T19:22:35Z

Yes, need to do a sync with the main branch anyway.

I had to do some messing around with configuration because the class scanner stopped working when I updated to Android Studio 2.0.0 and updated Gradle.
I am not positive what caused that issue, but it was something to do with the Dex loader.

sibelius · 2016-04-11T19:22:59Z

we want to release this as an alpha version of Sugar 2.0

bpappin · 2016-04-11T19:24:38Z

There are a lot of pull results that will need working through, I will try and get them merged shortly.

I suspect this code will need some cleanup and testing done as right not it works for me, but I haven't tried anywhere else.

…repo.

JonatanSalas · 2016-04-11T20:34:52Z

@bpappin There is no problem, we can do the clean up and test! Don't worry about that!

Please enter the commit message for your changes. Lines starting

bpappin · 2016-04-12T13:30:32Z

I'm having a lot of trouble with the merge, there are a lot of small things that change entire files.
I'm going to have to go through each change and try and match them.

bpappin · 2016-04-16T03:18:36Z

At this stage, I'm wondering if it would be easier to start with a clean head version and redo the changes.
It would take a while, but maybe less time than trying to merge.

sibelius · 2016-04-16T10:39:42Z

you could create a branch from master, then you could cherry-pick yours commits

bpappin · 2016-04-19T14:02:54Z

I'm just not finding the merge easy, to many little changes, and this week got busy.
It's going to take me hours that I just don't have time for at the moment.

I'll see if I can make some time for it, in a few days.

shobhik · 2016-05-29T07:38:41Z

Hi, not to sound ungrateful/whiny but when can we expect this to be merged successfully, or see a 2.0 release? I ask because I haven't seen any activity on this thread for a while so I have no idea what timeframe is involved.

We have ~4 apps using Sugar that will enter production in the near future. Data loss being a big deal in our industry, it would make all our lives easier if we didn't have to force our clients to reinstall between 1.x and 2.0 so I'd rather wait to release our apps with Sugar 2.0.

@bpappin @JonatanSalas I'm not the greatest at unit testing but am willing to do physical QA (time permitting) if that will expedite things.

Goes without saying I love this library and the hard work y'all have put into it!

sibelius · 2016-05-30T14:19:51Z

@shobhik you should talk to @satyan, he is the owner of this lib, he has the keys to deploy a new release.

@bpappin I think it is easy to close this PR and send a new one based on master version

maybe @shobhik could help u with this

bpappin · 2016-07-31T19:16:07Z

OK, so I finally have a few cycles to come back to this.
I'm considering simply forking a new branch and starting over, as there have been too many small changes to make it easy.

What's the status of this pull request from a project perspective at this point?

bpappin · 2023-06-02T20:42:04Z

I am assuming i can close this PR?

bpappin · 2023-06-02T20:42:16Z

Close as obsolete

bpappin added 8 commits March 28, 2016 17:15

Added ability to publish a modified fork version to the local maven r…

3114fa5

…epository.

Add methods to support writing a ContentProvider that understands Sug…

57a8ce7

…arORM.

Added programatic configuration and an alternate scheme generator tha…

023b752

…t simply drops tables and recreates them.

Added notification for content providers

7f62cb3

Fixing wrong id column name

c86eb42

Changed id column to use BaseColumns._ID and fixed corresponding tests.

6a172b1

Added schema generator class to manifest metadata tags. Renamed metad…

6cc2924

…ata tags to avoid conflicts with other libraries.

added ContentProvider notification.

c7c8e71

sibelius reviewed Mar 31, 2016
View reviewed changes

fixed typo maifest to manifest.

1325d7a

added documentation on using the ContentProvider and the new Drop Tab…

e6b5dfe

…le schema generator.

bpappin added 2 commits March 31, 2016 21:11

fixed header formatting

53c1a04

fixed typos

2c52591

bpappin changed the title ~~Major modifications~~ Major modifications: Addition of ContentProvider and column name changed from id to _id. Apr 1, 2016

bpappin mentioned this pull request Apr 1, 2016

Added ability to inject settings from application object on startup #281

Open

Merge branch 'master' of https://github.com/satyan/sugar into merge

1cf0280

# Conflicts: # library/src/main/java/com/orm/SchemaGenerator.java # library/src/main/java/com/orm/SugarContext.java # library/src/test/java/com/orm/SchemaGeneratorTest.java # sugar.iml

bpappin added 2 commits April 9, 2016 18:51

fixing build for android plugin 2.0.0

8c6670c

Android Studio 2.0.0 broke the class scanner, so this introduces some…

a9b7b5a

… changes to work around it.

This was referenced Apr 11, 2016

Sharing SQLite database between apps #570

Open

Content Provider? #79

Open

added script to easuly start an upstream pull, to sync with the main …

31996e7

…repo.

removed script.

f21b6ce

Please enter the commit message for your changes. Lines starting

JonatanSalas added PR: Needs Rebase tests Needed PR: Needs Review labels Apr 21, 2016

sibelius mentioned this pull request May 16, 2016

Can't use any primary key name? #597

Closed

sibelius assigned JonatanSalas May 30, 2016

backing up all changed before branching.

65d3e0a

bpappin closed this Jun 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Major modifications: Addition of ContentProvider and column name changed from id to _id. #556

Major modifications: Addition of ContentProvider and column name changed from id to _id. #556

bpappin commented Mar 30, 2016

mention-bot commented Mar 30, 2016

sibelius commented Mar 30, 2016

coveralls commented Mar 30, 2016

pguedes commented Mar 30, 2016

sibelius Mar 31, 2016

sibelius commented Mar 31, 2016

sibelius commented Mar 31, 2016

bpappin commented Apr 1, 2016

sibelius commented Apr 1, 2016

bpappin commented Apr 1, 2016

bpappin commented Apr 1, 2016

bpappin commented Apr 2, 2016

sibelius commented Apr 2, 2016

coveralls commented Apr 2, 2016

coveralls commented Apr 3, 2016

sibelius commented Apr 3, 2016

bpappin commented Apr 3, 2016

JonatanSalas commented Apr 7, 2016

bpappin commented Apr 11, 2016

sibelius commented Apr 11, 2016

bpappin commented Apr 11, 2016

JonatanSalas commented Apr 11, 2016

bpappin commented Apr 12, 2016

bpappin commented Apr 16, 2016 •

edited

Loading

sibelius commented Apr 16, 2016

bpappin commented Apr 19, 2016

shobhik commented May 29, 2016

sibelius commented May 30, 2016

bpappin commented Jul 31, 2016 •

edited

Loading

bpappin commented Jun 2, 2023

bpappin commented Jun 2, 2023

Major modifications: Addition of ContentProvider and column name changed from id to _id. #556

Major modifications: Addition of ContentProvider and column name changed from id to _id. #556

Conversation

bpappin commented Mar 30, 2016

mention-bot commented Mar 30, 2016

sibelius commented Mar 30, 2016

coveralls commented Mar 30, 2016

pguedes commented Mar 30, 2016

sibelius Mar 31, 2016

Choose a reason for hiding this comment

sibelius commented Mar 31, 2016

sibelius commented Mar 31, 2016

bpappin commented Apr 1, 2016

sibelius commented Apr 1, 2016

bpappin commented Apr 1, 2016

bpappin commented Apr 1, 2016

bpappin commented Apr 2, 2016

sibelius commented Apr 2, 2016

coveralls commented Apr 2, 2016

coveralls commented Apr 3, 2016

sibelius commented Apr 3, 2016

bpappin commented Apr 3, 2016

JonatanSalas commented Apr 7, 2016

bpappin commented Apr 11, 2016

sibelius commented Apr 11, 2016

bpappin commented Apr 11, 2016

JonatanSalas commented Apr 11, 2016

bpappin commented Apr 12, 2016

bpappin commented Apr 16, 2016 • edited Loading

sibelius commented Apr 16, 2016

bpappin commented Apr 19, 2016

shobhik commented May 29, 2016

sibelius commented May 30, 2016

bpappin commented Jul 31, 2016 • edited Loading

bpappin commented Jun 2, 2023

bpappin commented Jun 2, 2023

bpappin commented Apr 16, 2016 •

edited

Loading

bpappin commented Jul 31, 2016 •

edited

Loading