Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error information about sqlite keywords usage #557

Merged
merged 4 commits into from Apr 2, 2016
Merged

add error information about sqlite keywords usage #557

merged 4 commits into from Apr 2, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 31, 2016

No description provided.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @sibeliusseraphini, @RoyMontoya and @whoshuu to be potential reviewers

@bpappin
Copy link

bpappin commented Apr 1, 2016

Just a couple of suggestions:

  1. It might be easier to maintain as an array of keywords instead of a list. Since it only runs when the generator runs, and is immutable, the collection is a bit overkill.
  2. in createTableSQL(), you should output the name of the keyword in the error so the developer can easily figure out which column has a bad name.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.0%) to 70.461% when pulling a0dc1cc on geracervantes:master into 2358dae on satyan:master.

@JonatanSalas JonatanSalas merged commit 55c125d into chennaione:master Apr 2, 2016
reservedWords.add("WITH");
reservedWords.add("WITHOUT");}

public boolean isaReservedWords(String word){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be static

@sibelius
Copy link
Contributor

sibelius commented Apr 2, 2016

@geracervantes or @JonatanSalas, could someone change from Set to an Array

array of keywords instead of a list

and also address this:

in createTableSQL(), you should output the name of the keyword in the error so the developer can easily figure out which column has a bad name.

and use static method instead of creating a KeyWords object

@ghost
Copy link
Author

ghost commented Apr 2, 2016

working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants