Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the java.io.File handle from downloadVideo and downloadFile methods #2

Closed
binil opened this issue Mar 25, 2013 · 3 comments
Closed

Return the java.io.File handle from downloadVideo and downloadFile methods #2

binil opened this issue Mar 25, 2013 · 3 comments
Assignees
@rossrowe
Labels
Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest

Comments

@binil
Copy link

binil commented Mar 25, 2013

This will make the API easier to use when a report with the file's location needs to be created.
@ghost ghost assigned rossrowe Mar 26, 2013
@DylanLacey
Copy link
Contributor

Closing this as it's several years out of date.

If anyone wishes to re-open, can you provide some more details? The downloadX methods take a filepath as a String, which I imagine fulfils the requirement. What's the benefit of returning a File handle?

@DylanLacey
Copy link
Contributor

Reopening; Upon reading the code for this, it seems reasonable. The asset is only assigned a location, not a filename, and the filename can vary.

@DylanLacey DylanLacey reopened this May 18, 2018
@DylanLacey DylanLacey mentioned this issue May 18, 2018
Closed
@christian-bromann christian-bromann added the Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest label Oct 1, 2020
@sceiler
Copy link
Contributor

sceiler commented Apr 28, 2023

Closing as not applicable anymore.

@sceiler sceiler closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossrowe rossrowe

Labels
Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@binil @DylanLacey @christian-bromann @rossrowe @sceiler