Skip to content
This repository has been archived by the owner on Aug 16, 2020. It is now read-only.

Add a way to build the app without Play Services #7

Closed
Rudloff opened this issue Sep 29, 2018 · 2 comments
Closed

Add a way to build the app without Play Services #7

Rudloff opened this issue Sep 29, 2018 · 2 comments

Comments

@Rudloff
Copy link

Rudloff commented Sep 29, 2018

Is your feature request related to a problem? Please describe.
I am working on packaging ZimLX on F-Droid (#5).
play-services-awareness is a non-free library and we don't allow those so we had to remove it and the AwarenessWeatherAPI class. We also patched the preferences to enable OpenWeatherMap by default.
You can see the exact changes we made here: https://gitlab.com/fdroid/fdroiddata/blob/8a955a2a0f10e6824f3fe62310e4e869d8e3ea31/metadata/org.zimmob.zimlx.txt#L20

Describe the solution you'd like
It would be a lot easier for us to maintain the F-Droid package if this could be handled with a build variant that removes this dependency automatically.
Do you think that is something you could do?

Describe alternatives you've considered
Since this class comes from Lawnchair, I guess the solution could be shared with them.

Additional context
F-Droid can only include an app if it is entirely open-source and its dependencies are open-source as well.
We frequently remove non-free dependencies from apps but ou patches can break easily if the upstream files change, so it is way easier for us if this is handled by the upstream developer.

@saulhdev
Copy link
Owner

saulhdev commented Oct 1, 2018

Hello @Rudloff
I have decided to remove the weather api since this is not a feature I want to offer in the launcher.
the commit remove weather support fix this issue.

Thanks

@Rudloff
Copy link
Author

Rudloff commented Oct 1, 2018

OK, then it will be even easier for us to package the app.
Can you please ping me when you publish a new stable release that includes this change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants