Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.9: VisiData crashes on launch due to missing urllib3 #1436

Closed
jsvine opened this issue Jul 21, 2022 · 1 comment
Closed

v2.9: VisiData crashes on launch due to missing urllib3 #1436

jsvine opened this issue Jul 21, 2022 · 1 comment

Comments

@jsvine
Copy link
Contributor

jsvine commented Jul 21, 2022

Small description

Congrats on v2.9! Exciting to explore it! Unfortunately, one thing I noticed immediately: On a fresh install of VisiData (e.g., in a virtual environment), VisiData immediately crashes due to ModuleNotFoundError: No module named 'urllib3'. This seems to stem from loaders/unzip_http.py.

Expected result

VisiData launches successfully.

Actual result with screenshot

Traceback (most recent call last):
  File "[...]/bin/vd", line 3, in <module>
    import visidata.main
  File "[...]/visidata/__init__.py", line 110, in <module>
    import visidata.loaders.archive
  File "[...]/visidata/loaders/archive.py", line 4, in <module>
    from visidata.loaders import unzip_http
  File "[...]/visidata/loaders/unzip_http.py", line 30, in <module>
    import urllib3
ModuleNotFoundError: No module named 'urllib3'

(Running pip install urllib3 resolves this.)

Steps to reproduce with sample data and a .vd

python -m venv venv
source venv/bin/activate
pip install visidata==2.9
vd .

Additional context

  • VisiData 2.9
  • Python 3.10
  • MacOS
@jsvine jsvine added the bug label Jul 21, 2022
anjakefala added a commit that referenced this issue Jul 21, 2022
anjakefala added a commit that referenced this issue Jul 21, 2022
@anjakefala
Copy link
Collaborator

Thank you so much @jsvine! I am so grateful that you caught it and filed an issue so quickly. I just shipped v2.9.1. urllib3 is for now an optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants