Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor validate email otp and add firebase integration test #47

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

NYARAS
Copy link
Contributor

@NYARAS NYARAS commented Sep 30, 2021

Signed-off-by: Otieno Calvine nyarangaotieno@gmail.com

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>
@Salaton Salaton merged commit 926da6d into implement-ddd Sep 30, 2021
@Salaton Salaton deleted the firebase-infrastructure-tests branch September 30, 2021 13:13
Salaton pushed a commit that referenced this pull request Mar 21, 2022
* chore: implement ddd

* chore: restructure folder structure

* Improve dependency injection (#31)

* chore: refactor to use graph

* chore: improve dependency injection

Separate patient usecases from database implementation
Initialize all usecases with one single interactor
Break down Cloud FHIR and Firebase into a separate datastores

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

Co-authored-by: maxwellgithinji <maxwellgithinji@gmail.com>

* chore: port clinical models (#32)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: port more clinical implementation and improve dependency injection (#33)

Implement OCL as a service
Improve FHIR repository dependency injection

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: port patient anf fhir implementation into single usecase (#34)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: port more fhir and patient usecases (#35)

Make patient and fhir implementation agnostic i.e logic should be usecase specific

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: restore methods (#36)

* chore: return fhir datastore layer implementation (#37)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* add precondition checks (#38)

* chore: port onbaording isc implementation into there own usecases (#40)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* implement clinical patient usecases (#41)

* chore: implement fhir methods (#39)

* chore: add fhir infrustructure/repository integration tests (#45)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: add test usecases config (#46)

* add patient usecase unit tests (#44)

* chore: refactor validate email otp  and add firebase integration test (#47)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: add repository mocks and firebase unit test (#48)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* feat: add missing usecases and implement graph resolvers (#49)

Implement missing graphql resolvers and usecases

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: cleanup and acceptance tests (#50)

Remove unused configuration and add critical API acceptance tests

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: add more critical acceptance testing (#52)

Critical GraphQL patient related endpoints:
 - TestGraphQLEndEpisode
 - TestGraphQLStartEpisode
 - TestGraphQLStartEpisodeByBreakGlass
 - TestGraphQLStartEpisodeByOTP
 - TestGraphQGetPatient
 - TestGraphQLFindPatients
 - TestGraphQFindPatientsByMSISDN

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* add patient usecases integration tests (#51)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* ref: refactor ocl implementation (#53)

Improve usecase implementation and add acceptance tests

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: omit mock implementations from final coverage (#54)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: add ocl integration tests (#55)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chor: implement tests for fhir usecases methods (#42)

* add fhir-unit-tests (#56)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* move common constants to one place (#57)

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>

* chore: add fhir unit tests (#58)

* chore: refactor usecase test (#63)

* chore: fix todo usecase tests (#65)

* chore: fix todo usecase tests (#65) (#67)

* chore: update firebase version (#71)

Co-authored-by: maxwellgithinji <maxwellgithinji@gmail.com>
Co-authored-by: Kathurima Kimathi <41376826+KathurimaKimathi@users.noreply.github.com>
Co-authored-by: Otieno Calvine <35563516+NYARAS@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants