-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix todo usecase tests (#65) #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwellgithinji
force-pushed
the
fix-fhir-unittest-implementation
branch
9 times, most recently
from
October 7, 2021 05:46
24b834f
to
1098fc0
Compare
maxwellgithinji
force-pushed
the
fix-fhir-unittest-implementation
branch
from
October 7, 2021 05:47
1098fc0
to
1881ccf
Compare
NYARAS
approved these changes
Oct 7, 2021
Muchogoc
pushed a commit
that referenced
this pull request
Mar 18, 2022
KathurimaKimathi
pushed a commit
that referenced
this pull request
Mar 18, 2022
KathurimaKimathi
pushed a commit
that referenced
this pull request
Mar 18, 2022
Salaton
pushed a commit
that referenced
this pull request
Mar 21, 2022
* chore: implement ddd * chore: restructure folder structure * Improve dependency injection (#31) * chore: refactor to use graph * chore: improve dependency injection Separate patient usecases from database implementation Initialize all usecases with one single interactor Break down Cloud FHIR and Firebase into a separate datastores Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> Co-authored-by: maxwellgithinji <maxwellgithinji@gmail.com> * chore: port clinical models (#32) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: port more clinical implementation and improve dependency injection (#33) Implement OCL as a service Improve FHIR repository dependency injection Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: port patient anf fhir implementation into single usecase (#34) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: port more fhir and patient usecases (#35) Make patient and fhir implementation agnostic i.e logic should be usecase specific Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: restore methods (#36) * chore: return fhir datastore layer implementation (#37) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * add precondition checks (#38) * chore: port onbaording isc implementation into there own usecases (#40) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * implement clinical patient usecases (#41) * chore: implement fhir methods (#39) * chore: add fhir infrustructure/repository integration tests (#45) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: add test usecases config (#46) * add patient usecase unit tests (#44) * chore: refactor validate email otp and add firebase integration test (#47) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: add repository mocks and firebase unit test (#48) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * feat: add missing usecases and implement graph resolvers (#49) Implement missing graphql resolvers and usecases Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: cleanup and acceptance tests (#50) Remove unused configuration and add critical API acceptance tests Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: add more critical acceptance testing (#52) Critical GraphQL patient related endpoints: - TestGraphQLEndEpisode - TestGraphQLStartEpisode - TestGraphQLStartEpisodeByBreakGlass - TestGraphQLStartEpisodeByOTP - TestGraphQGetPatient - TestGraphQLFindPatients - TestGraphQFindPatientsByMSISDN Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * add patient usecases integration tests (#51) Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com> * ref: refactor ocl implementation (#53) Improve usecase implementation and add acceptance tests Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: omit mock implementations from final coverage (#54) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chore: add ocl integration tests (#55) Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com> * chor: implement tests for fhir usecases methods (#42) * add fhir-unit-tests (#56) Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com> * move common constants to one place (#57) Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com> * chore: add fhir unit tests (#58) * chore: refactor usecase test (#63) * chore: fix todo usecase tests (#65) * chore: fix todo usecase tests (#65) (#67) * chore: update firebase version (#71) Co-authored-by: maxwellgithinji <maxwellgithinji@gmail.com> Co-authored-by: Kathurima Kimathi <41376826+KathurimaKimathi@users.noreply.github.com> Co-authored-by: Otieno Calvine <35563516+NYARAS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Checklist
Summary*
Add the items tackled here as checklists
Structure*
proper
title that conforms to our MR title standardsTests
Sign off*
N/B: