-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquidsoap hanging during shutdown #843
Comments
Without a reproduction case, it is very difficult to answer (and if we were aware of such problems we would already have fixed those :)). The only recent related issue I can think of is #769, but it is related to jack and I suspect that you are not likely to use that? |
I am going to close this for now since we really don't have enough information. Feel free to reopen if you have a reproducible test case or at least a track, we'll be glad to help! |
Upgrade ocaml-duppy to 0.8.0, and recompile liquidsoap. |
Thanks @crocket, feel free to reopen if this was another bug. |
I found a simple fix for liquidsoap-1.3.7. It may apply to liquidsoap-1.3.6, too.
|
I still have liquidsoap (now 1.3.7) dying on me on shutdown. It might have to do something with a fast subsequent restart (which a client perhaps should not do, but can't prevent it). A grep for main:3 in the logs show the following: A successful restart:
Another succesful restart:
And the next one fails. Liquidsoap zombies out and has to be killed manually and is started the next morning:
Any more ideas? |
Did you compile liquidsoap against ocaml-duppy-0.8.0 or above? |
Crocket, yes, thank you, I tried so much stuff that I forget what I tried and what I did not try on so many systems :) The above output shows 'duppy=0.8.0' in the compiler flags, so I am pretty sure it's compiled against ocaml-duppy 0.8.0. |
Did you also patch ocaml-streamer? |
As part of reproducing #1045 I've found this issue and I think I'm hitting the same bug. on ocaml-duppy master (0207fdffa34d78e64ec8f98c7cdbc11c2bf49e65) Massive debug dump:
It doesn't look like it really wants to respond to SIGTERM:
Linux confirms this is a signal issue:
|
I'm still getting this confirmed by our control panel's technician, I have too little knowledge about ocaml. I see Jookia is seeing issues as well, I wonder if that will help the case. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue was closed for lack of activity. If you believe that it is still relevant, please confirm that it applies to the latest released version of liquidsoap and re-open the ticket. Thanks! |
Describe the bug
We're using liquidsoap 1.3.6, as a part of Cast-Control's MediaCP package. It works fine, but we have an issue where incidentally a customer will choose to restart liquidsoap, and it will hang during shutdown. An admin has to log in to the server and do a kill -9. The problem is that we cannot seem to reproduce it. I can restart liquidsoap hundreds of times without a problem.
Funny thing is that a succesful shutdown logs this (grepping for main in liquidsoap.log):
And an unsuccesful shutdown logs:
After this it becomes zombie and doesn't do anything anymore.
To Reproduce
Can't reproduce myself. Our customers do thousands of autodj restarts a week, and sometimes this issue pops up.
Expected behavior
I expect liquidsoap to shutdown nice and cleanly when it is asked to do so.
Version details
Install method
Installed using yum by mediacp (liquidsoap-1.3.6-80.4.x86_64), logs show:
I hope you guys have an idea what the problem could be.. (known issue I overlooked?)
The text was updated successfully, but these errors were encountered: