Use BIO_should_retry in flush #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Jun 2, 2023
CHANGES: - Raise an error when `Ssl.flush` isn't successful (savonet/ocaml-ssl#104, savonet/ocaml-ssl#120) - Add an API-compatible `Ssl.Runtime_lock` module. The functions in this module don't release the OCaml runtime lock. While they don't allow other OCaml threads to run concurrently, they don't perform any copying in the underlying data, leading certain workloads to be faster than their counterparts that release the lock. (savonet/ocaml-ssl#106) - Guarantee `Ssl.output_string` writes the whole string by retrying the operation with unwritten bytes (savonet/ocaml-ssl#103, savonet/ocaml-ssl#116) - Fix calls in C stubs that need to call `ERR_clear_error` before the underlying OpenSSL call (savonet/ocaml-ssl#118) - Add a module `Ssl.Error` to retrieve OpenSSL errors in a structured way (savonet/ocaml-ssl#119) - Deprecate Ssl.{SSLv23,SSLv3,TLSv1,TLSv1_1}, which were were formally deprecated in March 2021 and earlier (savonet/ocaml-ssl#115).
anmonteiro
pushed a commit
to craff/ocaml-ssl
that referenced
this pull request
Jun 2, 2023
bug fixes in c interface wrong way for checking if we need retry in Ssl.flush missplaced SSL_clear_error for shutdown and finish all Runtime_lock functions Added Error_want_retry_verify in ssl.ml/mli Added a safer conversion to type Ssl.ssl_error remove all raw_xxx functions and use shadowing Simplify error treatment wrong function name in error. added a comment to explain -2 in flush Use BIO_should_retry in flush (savonet#120) --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> fix issue savonet#103 for output_string, output_char and input_int (savonet#116) * fix issue savonet#103 for output_string output_char and input_int * Update CHANGES.md * Update CHANGES.md * Apply suggestions from code review --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> bug fixes in c interface (savonet#118) * bug fixes in c interface * wrong way for checking if we need retry in Ssl.flush * missplaced SSL_clear_error for whutdown * revert one change to put in a separate PR. * forgot one case * Update CHANGES.md --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> added comment not to forget to update macro in ssl_stubs.c when adding errors revert error treatment
anmonteiro
pushed a commit
to craff/ocaml-ssl
that referenced
this pull request
Jun 2, 2023
bug fixes in c interface wrong way for checking if we need retry in Ssl.flush missplaced SSL_clear_error for shutdown and finish all Runtime_lock functions Added Error_want_retry_verify in ssl.ml/mli Added a safer conversion to type Ssl.ssl_error remove all raw_xxx functions and use shadowing Simplify error treatment wrong function name in error. added a comment to explain -2 in flush Use BIO_should_retry in flush (savonet#120) --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> fix issue savonet#103 for output_string, output_char and input_int (savonet#116) * fix issue savonet#103 for output_string output_char and input_int * Update CHANGES.md * Update CHANGES.md * Apply suggestions from code review --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> bug fixes in c interface (savonet#118) * bug fixes in c interface * wrong way for checking if we need retry in Ssl.flush * missplaced SSL_clear_error for whutdown * revert one change to put in a separate PR. * forgot one case * Update CHANGES.md --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> added comment not to forget to update macro in ssl_stubs.c when adding errors revert error treatment
anmonteiro
pushed a commit
to craff/ocaml-ssl
that referenced
this pull request
Jun 2, 2023
bug fixes in c interface wrong way for checking if we need retry in Ssl.flush missplaced SSL_clear_error for shutdown and finish all Runtime_lock functions Added Error_want_retry_verify in ssl.ml/mli Added a safer conversion to type Ssl.ssl_error remove all raw_xxx functions and use shadowing Simplify error treatment wrong function name in error. added a comment to explain -2 in flush Use BIO_should_retry in flush (savonet#120) --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> fix issue savonet#103 for output_string, output_char and input_int (savonet#116) * fix issue savonet#103 for output_string output_char and input_int * Update CHANGES.md * Update CHANGES.md * Apply suggestions from code review --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> bug fixes in c interface (savonet#118) * bug fixes in c interface * wrong way for checking if we need retry in Ssl.flush * missplaced SSL_clear_error for whutdown * revert one change to put in a separate PR. * forgot one case * Update CHANGES.md --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> added comment not to forget to update macro in ssl_stubs.c when adding errors revert error treatment
anmonteiro
pushed a commit
that referenced
this pull request
Jun 2, 2023
bug fixes in c interface wrong way for checking if we need retry in Ssl.flush missplaced SSL_clear_error for shutdown and finish all Runtime_lock functions Added Error_want_retry_verify in ssl.ml/mli Added a safer conversion to type Ssl.ssl_error remove all raw_xxx functions and use shadowing Simplify error treatment wrong function name in error. added a comment to explain -2 in flush Use BIO_should_retry in flush (#120) --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> fix issue #103 for output_string, output_char and input_int (#116) * fix issue #103 for output_string output_char and input_int * Update CHANGES.md * Update CHANGES.md * Apply suggestions from code review --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> bug fixes in c interface (#118) * bug fixes in c interface * wrong way for checking if we need retry in Ssl.flush * missplaced SSL_clear_error for whutdown * revert one change to put in a separate PR. * forgot one case * Update CHANGES.md --------- Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> added comment not to forget to update macro in ssl_stubs.c when adding errors revert error treatment
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Jun 3, 2023
CHANGES: - Raise an error when `Ssl.flush` isn't successful (savonet/ocaml-ssl#104, savonet/ocaml-ssl#120) - Add an API-compatible `Ssl.Runtime_lock` module. The functions in this module don't release the OCaml runtime lock. While they don't allow other OCaml threads to run concurrently, they don't perform any copying in the underlying data, leading certain workloads to be faster than their counterparts that release the lock. (savonet/ocaml-ssl#106) - Guarantee `Ssl.output_string` writes the whole string by retrying the operation with unwritten bytes (savonet/ocaml-ssl#103, savonet/ocaml-ssl#116) - Fix calls in C stubs that need to call `ERR_clear_error` before the underlying OpenSSL call (savonet/ocaml-ssl#118) - Add a module `Ssl.Error` to retrieve OpenSSL errors in a structured way (savonet/ocaml-ssl#119) - Deprecate Ssl.{SSLv23,SSLv3,TLSv1,TLSv1_1}, which were were formally deprecated in March 2021 and earlier (savonet/ocaml-ssl#115).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.