Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindings for OpenSSL
CHANGES:
Ssl.flush
isn't successful (Fix flush savonet/ocaml-ssl#104, Use BIO_should_retry in flush savonet/ocaml-ssl#120)Ssl.Runtime_lock
module. The functions in this moduledon't release the OCaml runtime lock. While they don't allow other OCaml
threads to run concurrently, they don't perform any copying in the underlying
data, leading certain workloads to be faster than their counterparts that
release the lock. (Norelease+flush savonet/ocaml-ssl#106)
Ssl.output_string
writes the whole string by retrying theoperation with unwritten bytes (output_string should be a loop savonet/ocaml-ssl#103, fix issue #103 for output_string, output_char and input_int savonet/ocaml-ssl#116)
ERR_clear_error
before the underlyingOpenSSL call (bug fixes in c interface savonet/ocaml-ssl#118)
Ssl.Error
to retrieve OpenSSL errors in a structured way (Error functions savonet/ocaml-ssl#119)deprecated in March 2021 and earlier (Mark TLSv1, TLSv1_1, TLSv1_2 as deprecated savonet/ocaml-ssl#115).