Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rexml is required but is not in the Gemfile #70

Closed
bakku opened this issue Mar 26, 2021 · 3 comments
Closed

Rexml is required but is not in the Gemfile #70

bakku opened this issue Mar 26, 2021 · 3 comments

Comments

@bakku
Copy link

bakku commented Mar 26, 2021

Since this gem hasn't been released in a while the only possible way to use the pretty printing is to do this:

Gemfile:

source 'https://rubygems.org'

gem 'gyoku', git: 'https://github.com/savonrb/gyoku'

script.rb:

require 'bundler/setup'
require 'gyoku'

xml = Gyoku.xml({ document: "xy" }, { pretty_print: true })

This fails however since rexml is used for pretty printing, so the Gemfile must look like this to make the pretty printing work:

source 'https://rubygems.org'

gem 'gyoku', git: 'https://github.com/savonrb/gyoku'
gem 'rexml'

rexml should be included in the Gemfile of gyoku. It should not be necessary for the user of the library to include it in his/her Gemfile.

@olleolleolle
Copy link
Contributor

Can you try now, @bakku, if this works, I merged a change.

@bakku
Copy link
Author

bakku commented Mar 27, 2021

Works great, thanks! Didn't know it was related to Ruby 3 ... now I see why it was not a dependency of gyoku.. What about creating a new release so features such as these could be used without loading the library directly from github?

@olleolleolle
Copy link
Contributor

Excellent, then this issue can be closed. Thanks for verifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants