Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage Storage over Cookies for ngToken #370

Closed
MatthewVita opened this issue Dec 5, 2015 · 6 comments
Closed

Leverage Storage over Cookies for ngToken #370

MatthewVita opened this issue Dec 5, 2015 · 6 comments
Assignees
@MatthewVita
Labels
Development

Comments

@MatthewVita
Copy link
Contributor

No description provided.

@MatthewVita MatthewVita self-assigned this Dec 5, 2015
@MatthewVita MatthewVita added this to the Admin Dashboard Epic milestone Dec 5, 2015
@MatthewVita MatthewVita mentioned this issue Dec 5, 2015
Merged
@MatthewVita
Copy link
Contributor Author

in PR here: e6cb103

@MatthewVita
Copy link
Contributor Author

Still want to find out why library isn't sessionStorage. I'm going to try swapping out localStorage for sessionStorage and see what happens. Will then get in touch with the library authors with findings

@dmtroyer
Copy link
Contributor

Still want to find out why library isn't sessionStorage

If I had to guess, I would say because they want the ability to control Token expiration beyond just one browser session. I believe the default is seven days on the rails gem.

@MatthewVita
Copy link
Contributor Author

lynndylanhurley/ng-token-auth#244

@MatthewVita
Copy link
Contributor Author

^ that is the issue that I will work on in my spare time. We will use localStorage since I'm finding it makes more sense for our use case. closing

@MatthewVita
Copy link
Contributor Author

👍 for learning new things by experimentation and research!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewVita MatthewVita

Labels
Development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatthewVita @dmtroyer